Closed Bug 1421783 Opened 4 years ago Closed 4 years ago

jrmuizel.github.io/webrender/facebook-refresh.html only runs at 42fps on the reference hardware

Categories

(Core :: Graphics: WebRender, defect, P1)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: jrmuizel, Assigned: kvark)

References

(Blocks 1 open bug)

Details

(Whiteboard: [wr-mvp])

No description provided.
We're spending 17-18ms in the compositor.
https://perfht.ml/2im8Co2

Again most of the time is in texture upload but more (16% is in dispatching draw calls)
I have been looking into the upload issues.
Assignee: nobody → kvark
Status: NEW → ASSIGNED
Blocks: 1403189
Whiteboard: [wr-mvp] [triage]
Here's another profile that has blob images and image sharing turned on:
https://perfht.ml/2inBuMr
It's clearly the same old Angle upload issues, for the most part.
When I run this test with native GL driver we hit 60fps
I profiled the page with and without the change to STATIC_DRAW on my AMD Windows machine at home.
The CPU Compositor time seems to drop from roughly 9.3ms to 6.3ms and the framerate is slightly improved.
Gecko profile shows us spending 4% of time in the PBO updates with the fix, so I think it's a win.
23% in swap buffers
47% in render
  30% in blend_func_separate

Looks like another Angle issue ^. Will investigate tomorrow
Priority: -- → P1
Whiteboard: [wr-mvp] [triage] → [wr-mvp]
Jeff, have you got the updated numbers with WR that uses `Immediate` style texture uploads on Angle?
Flags: needinfo?(jmuizelaar)
Yeah, this runs much better. We spend minimal time on the Renderer thread (https://perfht.ml/2nDWh01)

We can probably mark this as fixed for now.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Flags: needinfo?(jmuizelaar)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.