1421783 - jrmuizel.github.io/webrender/facebook-refresh.html only runs at 42fps on the reference hardware

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Comment 1

[Jeff Muizelaar [:jrmuizel]]

We're spending 17-18ms in the compositor.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

https://perfht.ml/2im8Co2

Again most of the time is in texture upload but more (16% is in dispatching draw calls)

Comment 3

[Dzmitry Malyshau [:kvark]]

I have been looking into the upload issues.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Here's another profile that has blob images and image sharing turned on:
https://perfht.ml/2inBuMr

Comment 5

[Dzmitry Malyshau [:kvark]]

It's clearly the same old Angle upload issues, for the most part.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

When I run this test with native GL driver we hit 60fps

Comment 7

[Dzmitry Malyshau [:kvark]]

I profiled the page with and without the change to STATIC_DRAW on my AMD Windows machine at home.
The CPU Compositor time seems to drop from roughly 9.3ms to 6.3ms and the framerate is slightly improved.
Gecko profile shows us spending 4% of time in the PBO updates with the fix, so I think it's a win.

Comment 8

[Dzmitry Malyshau [:kvark]]

23% in swap buffers
47% in render
  30% in blend_func_separate

Looks like another Angle issue ^. Will investigate tomorrow

Comment 9

[Dzmitry Malyshau [:kvark]]

Jeff, have you got the updated numbers with WR that uses `Immediate` style texture uploads on Angle?

Comment 10

[Jeff Muizelaar [:jrmuizel]]

Yeah, this runs much better. We spend minimal time on the Renderer thread (https://perfht.ml/2nDWh01)

We can probably mark this as fixed for now.