1421818 - Stop using Direct2D with WebRender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Jeff Muizelaar [:jrmuizel]]

Direct2D probably won't be very helpful

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Andrew knows something about what we are doing here and about how to fix it.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: 0001-Bug-1421818-Disable-D2D-backend-if-WebRender-is-enab.patch

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 8933744 [details] [diff] [review]
0001-Bug-1421818-Disable-D2D-backend-if-WebRender-is-enab.patch

Disabled the GPU process for the tests because the reftest reporting is accurate then :).

try (WR enabled, GPU process disabled + hack to allow WR): https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5c07937616c0c1c74f284a0329399df09d5caea&selectedJob=149167341

WebRender is enabled and skia is used as the backend.

> 12:43:42     INFO - REFTEST INFO | {"isDebugBuild":true,"xulRuntime":{"widgetToolkit":"windows","OS":"WINNT","XPCOMABI":"x86_64-msvc"},"smallScreen":false,"d2d":true,"dwrite":true,"gpuProcess":false,"azureCairo":false,"azureSkia":true,"skiaContent":true,"azureSkiaGL":0,"contentSameGfxBackendAsCanvas":true,"layersGPUAccelerated":true,"d3d11":false,"d3d9":false,"layersOpenGL":false,"webrender":true,"layersOMTC":true,"advancedLayers":false,"layerChecksEnabled":false,"retainedDisplayList":true,"Android":false,"cocoaWidget":false,"gtkWidget":false,"qtWidget":false,"winWidget":true,"transparentScrollbars":false,"AddressSanitizer":false,"webrtc":true,"retainedDisplayLists":true,"compareRetainedDisplayLists":false,"stylo":true,"styloVsGecko":false,"skiaPdf":false,"release_or_beta":false,"http":{"userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0","appName":"Mozilla","appVersion":"5.0","platform":"Windows","oscpu":"Windows NT 10.0; Win64; x64","misc":"rv:59.0"},"haveTestPlugin":true,"windowsDefaultTheme":true,"nativeThemePref":true,"gpuProcessForceEnabled":false,"prefs":{},"browserIsRemote":true,"asyncPan":true,"usesRepeatResampling":true}

try (WR disabled, GPU process disabled): https://treeherder.mozilla.org/#/jobs?repo=try&revision=7633ad9e5a50a45b2116ac611f1c65e04a790c66

WebRender is disabled, skia/cairo are not the default backends, and D2D is.

> 12:43:29     INFO - REFTEST INFO | {"isDebugBuild":true,"xulRuntime":{"widgetToolkit":"windows","OS":"WINNT","XPCOMABI":"x86_64-msvc"},"smallScreen":false,"d2d":true,"dwrite":true,"gpuProcess":false,"azureCairo":false,"azureSkia":false,"skiaContent":false,"azureSkiaGL":0,"contentSameGfxBackendAsCanvas":true,"layersGPUAccelerated":true,"d3d11":true,"d3d9":false,"layersOpenGL":false,"webrender":false,"layersOMTC":true,"advancedLayers":true,"layerChecksEnabled":true,"retainedDisplayList":true,"Android":false,"cocoaWidget":false,"gtkWidget":false,"qtWidget":false,"winWidget":true,"transparentScrollbars":false,"AddressSanitizer":false,"webrtc":true,"retainedDisplayLists":true,"compareRetainedDisplayLists":false,"stylo":true,"styloVsGecko":false,"skiaPdf":false,"release_or_beta":false,"http":{"userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0","appName":"Mozilla","appVersion":"5.0","platform":"Windows","oscpu":"Windows NT 10.0; Win64; x64","misc":"rv:59.0"},"haveTestPlugin":true,"windowsDefaultTheme":true,"nativeThemePref":true,"gpuProcessForceEnabled":false,"prefs":{},"browserIsRemote":true,"asyncPan":true,"usesRepeatResampling":true}

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

No GPU process should work, no-e10s would be bad because of WR+ANGLE+WebGL

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Milan Sreckovic [:milan] from comment #4)
> No GPU process should work, no-e10s would be bad because of WR+ANGLE+WebGL

It was just a hack because the reporting for the default content backend in the reftests changes depending on whether or not the GPU process is in use.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8933744 [details] [diff] [review]
0001-Bug-1421818-Disable-D2D-backend-if-WebRender-is-enab.patch

Review of attachment 8933744 [details] [diff] [review]:
-----------------------------------------------------------------

Can we break things into more logical pieces than Pre and Post?

Comment 7

[Darkspirit]

(In reply to Andrew Osmond [:aosmond])
Has bug 1422288 comment 13 done what you wanted to do here?

Comment 8

[Andrew Osmond [:aosmond] (he/him)]

Attachment: 0001-Bug-1421818-Disable-D2D-backend-if-WebRender-is-enab.patch, v2

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9922610d010e
Disable D2D backend if WebRender is enabled. r=jrmuizel

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/9922610d010e

Comment 11

[Kartikaya Gupta (email:[e-mail])]

I don't know if this patch worked. The sandbox dump for reftests on windows10-64-qr (e.g. [1]) show d2d:true. Is this expected?

[1] https://treeherder.mozilla.org/logviewer.html#?job_id=172336804&repo=try&lineNumber=1675

Comment 12

[Sotaro Ikeda [:sotaro]]

By the way Bug 1413392 re-enabled d2d only for canvas.