1421819 - Only create webrtc::call() object on video calls

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P1)

Description

[Nils Ohlmeier [:drno]]

Every time a PeerConnection gets instantiated we create a webrtc::call() object, which itself starts two threads. But none of this is needed for PeerConnections which don't use any video.

Note: this will change once the Audio pieces switch over to use the Call object as well. But even then we should not spin up these threads for data channel only PeerConnections.

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: Bug 1421819: only init Call object when really needed.

Review commit: https://reviewboard.mozilla.org/r/204084/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204084/

Comment 2

[Nils Ohlmeier [:drno]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0765ba713edb4455ed6fa40dc35fe0e07508f58

Comment 3

[Byron Campen [:bwc]]

Comment on attachment 8933109 [details]
Bug 1421819: only init Call object when really needed.

https://reviewboard.mozilla.org/r/204084/#review209928

Comment 4

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s afadf176e29c -d a3fd8af4122e: rebasing 436840:afadf176e29c "Bug 1421819: only init Call object when really needed. r=bwc" (tip)
other [source] changed media/webrtc/signaling/src/peerconnection/MediaPipelineFactory.cpp which local [dest] deleted
use (c)hanged version, leave (d)eleted, or leave (u)nresolved? u
merging media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.cpp
warning: conflicts while merging media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 5

[Nils Ohlmeier [:drno]]

Attachment: Bug 1421819: only init Call object in Tranceivers.

Review commit: https://reviewboard.mozilla.org/r/204468/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204468/

Comment 6

[Byron Campen [:bwc]]

Comment on attachment 8933523 [details]
Bug 1421819: only init Call object in Tranceivers.

https://reviewboard.mozilla.org/r/204468/#review210596

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fad08f2edb7e
only init Call object in Tranceivers. r=bwc

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/fad08f2edb7e