Closed Bug 1421871 Opened 2 years ago Closed 2 years ago

Content client decision making doesn't repeat when content type or component alpha changes

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox58 --- fixed
firefox59 --- fixed

People

(Reporter: rhunt, Assigned: rhunt)

References

Details

Attachments

(1 file)

Whoops, looks like this line [1] got mistakenly dropped in bug 1416921.

[1] https://hg.mozilla.org/integration/mozilla-inbound/rev/614d705be06c#l3.283
Attached patch continue.patchSplinter Review
Assignee: nobody → rhunt
Attachment #8933161 - Flags: review?(bas)
Blocks: 1416921
Attachment #8933161 - Flags: review?(bas) → review+
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/492835cff932
Add back mistakenly removed continue statement (bug 1421871, r=bas)
https://hg.mozilla.org/mozilla-central/rev/492835cff932
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Comment on attachment 8933161 [details] [diff] [review]
continue.patch

Approval Request Comment
[Feature/Bug causing the regression]: A line was erroneously removed in bug 1416921
[User impact if declined]: Not entirely sure, web content with transparent layers and text could run into edge cases when switching modes to component alpha and not resizing the buffer or respecting resampling.
[Is this code covered by automated tests?]: Apparently not
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: Uplift bug 1416921 before this bug
[Is the change risky?]: No
[Why is the change risky/not risky?]: This is reverting to prior behavior
[String changes made/needed]: None
Attachment #8933161 - Flags: approval-mozilla-beta?
Comment on attachment 8933161 [details] [diff] [review]
continue.patch

Required by bug 1416921. Beta58+.
Attachment #8933161 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.