1421871 - Content client decision making doesn't repeat when content type or component alpha changes

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Ryan Hunt [:rhunt] (on leave until early May)]

Whoops, looks like this line [1] got mistakenly dropped in bug 1416921.

[1] https://hg.mozilla.org/integration/mozilla-inbound/rev/614d705be06c#l3.283

Comment 1

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: continue.patch

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/492835cff932
Add back mistakenly removed continue statement (bug 1421871, r=bas)

Comment 3

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/492835cff932

Comment 4

[Ryan Hunt [:rhunt] (on leave until early May)]

Comment on attachment 8933161 [details] [diff] [review]
continue.patch

Approval Request Comment
[Feature/Bug causing the regression]: A line was erroneously removed in bug 1416921
[User impact if declined]: Not entirely sure, web content with transparent layers and text could run into edge cases when switching modes to component alpha and not resizing the buffer or respecting resampling.
[Is this code covered by automated tests?]: Apparently not
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: Uplift bug 1416921 before this bug
[Is the change risky?]: No
[Why is the change risky/not risky?]: This is reverting to prior behavior
[String changes made/needed]: None

Comment 5

[Gerry Chang [:gchang]]

Comment on attachment 8933161 [details] [diff] [review]
continue.patch

Required by bug 1416921. Beta58+.

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/releases/mozilla-beta/rev/810f9fabc684