1421958 - OfferToReceiveVideo and OfferToReceiveAudio should be of type Boolean not Long

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Description

[Christoph Diehl [:posidron]]

The W3C spec defines |offerToReceiveVideo| and |offerToReceiveAudio| as "Boolean".

https://w3c.github.io/webrtc-pc/#dom-rtcofferoptions-offertoreceiveaudio


In our implementation those keys are defined as "Long".

https://searchfox.org/mozilla-central/rev/be78e6ea9b10b1f5b2b3b013f01d86e1062abb2b/dom/webidl/RTCPeerConnection.webidl#70



To illustrate the problem:

o[0] = new RTCPeerConnection({iceServers: [{"urls":"stun:23.21.150.121"}]})
o[0].createOffer({offerToReceiveVideo: 2147483647, offerToReceiveAudio: 2147483647})

or with negative values:

o[0].createOffer({offerToReceiveVideo: -1, offerToReceiveAudio: -1})


Both versions lead to an OOM condition.

Comment 1

[Dan Minor [:dminor]]

Attachment: Switch long to boolean

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4b92d1566a6
OfferToReceiveVideo and OfferToReceiveAudio should be of type Boolean not Long; r=smaug,jib

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f4b92d1566a6