1422031 - Remove remaining nav-button style parts in extensions

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement)

Description

[Richard Marti (:Paenglab)]

Bug 1364333 removed already a lot of the nav-buttons but not everything.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: remove-nav-button.patch

This removes the no more used styles and file.

Robert, is it okay when I add a ID to the <vbox> to get a anchor, so I can add a overlay in TB to bring back the nav-buttons in TB?

Comment 2

[Richard Marti (:Paenglab)]

Thanks

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7eb30f8e43cb
Remove remaining nav-button style parts in extensions. r=rhelmer

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/7eb30f8e43cb

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 8933348 [details] [diff] [review]
remove-nav-button.patch

Approval Request Comment
[User impact if declined]: On FX no impact, but TB has no navigation buttons in add-on manager.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: Can't been verified as it's a removal of code
[Needs manual test from QE? If yes, steps to reproduce]: no
[Is the change risky?]: should not be
[Why is the change risky/not risky?]: Removal of dead m-c code
[String changes made/needed]: no

Comment 6

[Gerry Chang [:gchang]]

Comment on attachment 8933348 [details] [diff] [review]
remove-nav-button.patch

Take this for TB to fix navigation buttons issue in add-on manager. Beta58+.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/25efcc3f4349

Comment 8

[CosminB]

Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!

Comment 9

[Richard Marti (:Paenglab)]

It's a removal of in FX not used and visible elements -> not possible to test.