Closed Bug 1422031 Opened 6 years ago Closed 6 years ago

Remove remaining nav-button style parts in extensions

Categories

(Toolkit :: Add-ons Manager, enhancement)

Product:
Toolkit
Component:
Add-ons Manager
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox58 --- fixed
firefox59 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

remove-nav-button.patch
4.51 KB, patch
aswan
: review+
gchang
: approval-mozilla-beta+
Details | Diff | Splinter Review 
Bug 1364333 removed already a lot of the nav-buttons but not everything.
This removes the no more used styles and file.

Robert, is it okay when I add a ID to the <vbox> to get a anchor, so I can add a overlay in TB to bring back the nav-buttons in TB?
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8933348 - Flags: review?(rhelmer)
Attachment #8933348 - Flags: review?(rhelmer) → review?(aswan)
Attachment #8933348 - Flags: review?(aswan) → review+
Thanks
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7eb30f8e43cb
Remove remaining nav-button style parts in extensions. r=rhelmer
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7eb30f8e43cb
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Comment on attachment 8933348 [details] [diff] [review]
remove-nav-button.patch

Approval Request Comment
[User impact if declined]: On FX no impact, but TB has no navigation buttons in add-on manager.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: Can't been verified as it's a removal of code
[Needs manual test from QE? If yes, steps to reproduce]: no
[Is the change risky?]: should not be
[Why is the change risky/not risky?]: Removal of dead m-c code
[String changes made/needed]: no
Attachment #8933348 - Flags: approval-mozilla-beta?
Comment on attachment 8933348 [details] [diff] [review]
remove-nav-button.patch

Take this for TB to fix navigation buttons issue in add-on manager. Beta58+.
Attachment #8933348 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!
Flags: needinfo?(richard.marti)
It's a removal of in FX not used and visible elements -> not possible to test.
Flags: needinfo?(richard.marti) → qe-verify-
You need to log in before you can comment on or make changes to this bug.