1422106 - Synced Tabs sidebar and panel need to show unverified state

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Description

[Ryan Feeley [:rfeeley]]

Attachment: unverified.png

Before the account has been verified, the Synced Tabs sidebar and panel should show the broken hearted illustration with the existing copy from prefs ([e-mail] is not verified.)

Comment 1

[Edouard Oger [:eoger]]

Attachment: Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel.

Review commit: https://reviewboard.mozilla.org/r/204374/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204374/

Comment 2

[Edouard Oger [:eoger]]

Stashing this until rfeeley can come up with a wording that doesn't include the email.

Comment 3

[Ryan Feeley [:rfeeley]]

"Your account needs to be verified."

Button: "Open Sync Preferences"

Based on half of a string from here:
https://hg.mozilla.org/l10n/gecko-strings/file/default/mobile/android/base/sync_strings.dtd

Comment 4

[Edouard Oger [:eoger]]

Comment on attachment 8933458 [details]
Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/204374/diff/1-2/

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8933458 [details]
Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel.

https://reviewboard.mozilla.org/r/204374/#review210028

I'm fine with this if Ryan prefers it without the email address in the wording, but there wouldn't be a problem if he preferred it with the email (and in which case, we should do that instead)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3aff028846c0
Show broken heart when unverified in synced tabs sidebar/panel. r=markh

Comment 7

[Dorel Luca [:dluca]]

Backed out changeset 3aff028846c0 (bug 1422106) for failing syncedtabs/test/xpcshell/test_SyncedTabsDeckComponent.js and browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js r=backout on a CLOSED TREE

https://hg.mozilla.org/integration/autoland/rev/51f87fb4c263e28b94dd6334f4a5cd6125c9ff30

https://treeherder.mozilla.org/logviewer.html#?job_id=149181140&repo=autoland&lineNumber=2652

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=3aff028846c038edd23b632702781591a670693d

Comment 8

[Edouard Oger [:eoger]]

Comment on attachment 8933458 [details]
Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/204374/diff/2-3/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ca98c1618a6
Show broken heart when unverified in synced tabs sidebar/panel. r=markh

Comment 10

[Dorel Luca [:dluca]]

Backed out changeset 1ca98c1618a6 (bug 1422106) for failing browser/components/customizableui/test/browser_synced_tabs_menu.js r=backout on a CLOSED TREE

https://hg.mozilla.org/integration/autoland/rev/ecc5c1b8efc4111dfa9aba2f49666c9edbe5fbd6

https://treeherder.mozilla.org/logviewer.html#?job_id=149216924&repo=autoland&lineNumber=3942

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=1ca98c1618a65139d690b475a0ff9fd1160679fb

Comment 11

[Edouard Oger [:eoger]]

Comment on attachment 8933458 [details]
Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/204374/diff/3-4/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c60850f84692
Show broken heart when unverified in synced tabs sidebar/panel. r=markh

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c60850f84692