Closed Bug 1422106 Opened 4 years ago Closed 4 years ago

Synced Tabs sidebar and panel need to show unverified state

Categories

(Firefox :: Sync, defect, P1)

55 Branch
defect

Tracking

()

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: rfeeley, Assigned: eoger)

Details

Attachments

(2 files)

Attached image unverified.png
Before the account has been verified, the Synced Tabs sidebar and panel should show the broken hearted illustration with the existing copy from prefs (user@example.com is not verified.)
Assignee: nobody → eoger
Status: NEW → ASSIGNED
Priority: -- → P1
Stashing this until rfeeley can come up with a wording that doesn't include the email.
"Your account needs to be verified."

Button: "Open Sync Preferences"

Based on half of a string from here:
https://hg.mozilla.org/l10n/gecko-strings/file/default/mobile/android/base/sync_strings.dtd
Comment on attachment 8933458 [details]
Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel.

https://reviewboard.mozilla.org/r/204374/#review210028

I'm fine with this if Ryan prefers it without the email address in the wording, but there wouldn't be a problem if he preferred it with the email (and in which case, we should do that instead)
Attachment #8933458 - Flags: review?(markh) → review+
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3aff028846c0
Show broken heart when unverified in synced tabs sidebar/panel. r=markh
Backed out changeset 3aff028846c0 (bug 1422106) for failing syncedtabs/test/xpcshell/test_SyncedTabsDeckComponent.js and browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js r=backout on a CLOSED TREE

https://hg.mozilla.org/integration/autoland/rev/51f87fb4c263e28b94dd6334f4a5cd6125c9ff30

https://treeherder.mozilla.org/logviewer.html#?job_id=149181140&repo=autoland&lineNumber=2652

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=3aff028846c038edd23b632702781591a670693d
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1ca98c1618a6
Show broken heart when unverified in synced tabs sidebar/panel. r=markh
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c60850f84692
Show broken heart when unverified in synced tabs sidebar/panel. r=markh
https://hg.mozilla.org/mozilla-central/rev/c60850f84692
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.