Closed Bug 1422177 Opened 7 years ago Closed 6 years ago

Add tests to verify that moz-icon is unlinkable from the web

Categories

(Core :: Security: CAPS, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file)

We're removing access in bug 1222924.

We can probably just add some cases to https://searchfox.org/mozilla-central/source/caps/tests/mochitest/browser_checkloaduri.js .
Comment on attachment 8934188 [details]
Bug 1422177 - add tests for moz-icon being non-linkable from the web,

https://reviewboard.mozilla.org/r/205132/#review210630

LGTM, I'm not a module owner or peer but I suspect that doesn't matter given it's just a test.
Attachment #8934188 - Flags: review?(jkt) → review+
(In reply to Jonathan Kingston [:jkt] from comment #2)
> Comment on attachment 8934188 [details]
> Bug 1422177 - add tests for moz-icon being non-linkable from the web,
> 
> https://reviewboard.mozilla.org/r/205132/#review210630
> 
> LGTM, I'm not a module owner or peer but I suspect that doesn't matter given
> it's just a test.

I... I don't actually know. I guess I can just ask Boris to rubberstamp this, too...
Attachment #8934188 - Flags: review?(bzbarsky)
Comment on attachment 8934188 [details]
Bug 1422177 - add tests for moz-icon being non-linkable from the web,

https://reviewboard.mozilla.org/r/205132/#review212016
Attachment #8934188 - Flags: review?(bzbarsky) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c9670bff5a68
add tests for moz-icon being non-linkable from the web, r=bz,jkt
https://hg.mozilla.org/mozilla-central/rev/c9670bff5a68
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: