Closed Bug 1422244 Opened 2 years ago Closed 2 years ago

Change the dark theme text selection color of CodeMirror

Categories

(DevTools :: Source Editor, defect, P3)

57 Branch
defect

Tracking

(firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: malikanshul29, Assigned: malikanshul29)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171112125346

Steps to reproduce:

Original issue: https://github.com/devtools-html/debugger.html/issues/4765


Actual results:

Currently in dark mode Debugger, selected text is difficult to read because of the light blue highlight color.


Expected results:

Let's use this color instead: #353B48. (It's the same color as the Inspector's line-hover color.)
Component: Untriaged → Developer Tools: Debugger
Attached patch o.patch (obsolete) — Splinter Review
Attachment #8933565 - Flags: review?(jlaster)
Component: Developer Tools: Debugger → Developer Tools: Source Editor
Summary: Color change for Dark Debugger selected text readability (Photon polish uplift) → Change the dark theme text selection color of CodeMirror
Assignee: nobody → malikanshul29
Priority: -- → P3
Attachment #8933565 - Flags: review?(jlaster) → review?(gl)
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 8933565 [details] [diff] [review]
o.patch

Review of attachment 8933565 [details] [diff] [review]:
-----------------------------------------------------------------

I have made the fix for this.

::: devtools/client/themes/dark-theme.css
@@ +205,4 @@
>  }
>  
>  .cm-s-mozilla.CodeMirror-focused .CodeMirror-selected { /* selected text (focused) */
> +  background: #353B48;

This should not actually map to the hardcoded values and instead map to var(--theme-selection-background-hover) which is defined in variables.css
Attachment #8933565 - Flags: review?(gl) → review+
Attached patch 1422244.patchSplinter Review
Attachment #8933565 - Attachment is obsolete: true
Attachment #8935081 - Flags: review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4bedf3a1a515
Change codemirror text selection background color in dark theme. r=gl DONTBUILD
https://hg.mozilla.org/mozilla-central/rev/4bedf3a1a515
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.