1422244 - Change the dark theme text selection color of CodeMirror

Status: RESOLVED FIXED

(DevTools :: Source Editor, defect, P3)

Description

[malikanshul29]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171112125346

Steps to reproduce:

Original issue: https://github.com/devtools-html/debugger.html/issues/4765


Actual results:

Currently in dark mode Debugger, selected text is difficult to read because of the light blue highlight color.


Expected results:

Let's use this color instead: #353B48. (It's the same color as the Inspector's line-hover color.)

Comment 1

[malikanshul29]

Attachment: o.patch

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8933565 [details] [diff] [review]
o.patch

Review of attachment 8933565 [details] [diff] [review]:
-----------------------------------------------------------------

I have made the fix for this.

::: devtools/client/themes/dark-theme.css
@@ +205,4 @@
>  }
>  
>  .cm-s-mozilla.CodeMirror-focused .CodeMirror-selected { /* selected text (focused) */
> +  background: #353B48;

This should not actually map to the hardcoded values and instead map to var(--theme-selection-background-hover) which is defined in variables.css

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1422244.patch

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4bedf3a1a515
Change codemirror text selection background color in dark theme. r=gl DONTBUILD

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4bedf3a1a515