1422257 - Make FinderHighlighter not use -moz-border-*-colors.

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect, P1)

Description

[Emilio Cobos Álvarez (:emilio)]

.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1422257: Make FinderHighlighter not use -moz-border-*-colors.

I was going to use box-shadow to make the same effect we have now, but I got
into the intersection logic and I wasn't very excited about rewriting it in
terms of shadow offsets, so came up with this, which IMO looks equally good /
better.

Review commit: https://reviewboard.mozilla.org/r/204526/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204526/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8933585 [details]
Bug 1422257: Make FinderHighlighter not use -moz-border-*-colors.

https://reviewboard.mozilla.org/r/204526/#review210114

WFM, certainly in terms of "make it not break when `moz-border-*-color` support disappears". We can tweak style separately/later if necessary. Thanks for the quick patch!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c677e05432e8
Make FinderHighlighter not use -moz-border-*-colors. r=Gijs

Comment 4

[:Gijs (he/him)]

(Taking this off some tracking radars for 58 etc.)

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c677e05432e8