Closed Bug 1422277 Opened 2 years ago Closed 2 years ago

A single event for captive-portal "done"

Categories

(Core :: Networking, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: bagder, Assigned: valentin)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

There's right now an observer-event that gets sent when the user has successfully signed into a captive portal but there's no easy comparable alternative to know when the situation is deemed to have no captive portal at all.

It would be beneficial if either the "captive-portal-login-success" would also be generated when there's success without login or, perhaps better name wise, if there would be another event generated when the captive portal check confirmed that there's no portal present.

I have a pending use case where I want to delay starting my service until we know there's no portal in the way.
Assignee: nobody → valentin.gosu
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [necko-triaged]
Comment on attachment 8933611 [details]
Bug 1422277 - Add an observer notification for when the captive portal detection is "done"

https://reviewboard.mozilla.org/r/204560/#review210142

Excellent!
Attachment #8933611 - Flags: review?(daniel) → review+
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ab96653f9122
Add an observer notification for when the captive portal detection is "done" r=bagder
https://hg.mozilla.org/mozilla-central/rev/ab96653f9122
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.