1422322 - Autophone - handle geckoview_example https://mozilla.org loads in analyze_logcat

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

If geckoview_example is started without providing a url to load, it will by default load mozilla.org. This *may* cause confusion in determining the proper page load stop messages during analyze_logcat.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: bug-1422322-analyze_logcat-v1.patch

Comment 2

[Bob Clary [:bc] (inactive)]

Attachment: bug-1422322-create_profile-v1.patch

This patch fixes an existing bug in create_profile where the page load stop regular expression was too specific for Fennec and failed to work for geckoview_example. It also handles the cases where the geckoview_example page load messages may be for about:blank or https://mozilla.org/.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8933661 [details] [diff] [review]
bug-1422322-analyze_logcat-v1.patch

Review of attachment 8933661 [details] [diff] [review]:
-----------------------------------------------------------------

::: tests/s1s2test.py
@@ -329,3 @@
>          re_about_blank_start = re.compile('%s I/GeckoViewActivity.*Starting to load page at about:blank' %
>                                            logcat_prefix)
> -        re_about_blank_stop = re.compile('%s I/GeckoViewActivity.*Stopping page load' %

do we need to remove re_about_blank_stop from anywhere?  Or was this not used?

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8933663 [details] [diff] [review]
bug-1422322-create_profile-v1.patch

Review of attachment 8933663 [details] [diff] [review]:
-----------------------------------------------------------------

nice

Comment 5

[Bob Clary [:bc] (inactive)]

(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #3)
> Comment on attachment 8933661 [details] [diff] [review]
> bug-1422322-analyze_logcat-v1.patch
> 
> Review of attachment 8933661 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: tests/s1s2test.py
> @@ -329,3 @@
> >          re_about_blank_start = re.compile('%s I/GeckoViewActivity.*Starting to load page at about:blank' %
> >                                            logcat_prefix)
> > -        re_about_blank_stop = re.compile('%s I/GeckoViewActivity.*Stopping page load' %
> 
> do we need to remove re_about_blank_stop from anywhere?  Or was this not
> used?

I changed the test to use the re_throbber_stop_time to detect the zerdatime ... - page load stop instead of the Stopping page load. This will ignore the page load stop for the previous page load start.

Comment 6

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/ae9bc09e48dc3bcafa8bb58ccb96063709f5d815
https://github.com/mozilla/autophone/commit/26b52bd49e21d38ecf4d8536e91655f371ba678b
deploying shortly.