Closed
Bug 1422363
Opened 7 years ago
Closed 7 years ago
enable readability-static-accessed-through-instance in the static analysis
Categories
(Developer Infrastructure :: Source Code Analysis, enhancement)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox59 fixed)
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
No false positive, improve the code, let's enable it:
https://clang.llvm.org/extra/clang-tidy/checks/readability-static-accessed-through-instance.html
We don't have much occurrences of that in our code and there is no false positive.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → sledru
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8933733 [details]
Bug 1422363 - Enable readability-static-accessed-through-instance in the static analysis
https://reviewboard.mozilla.org/r/204678/#review210578
Attachment #8933733 -
Flags: review?(bpostelnicu) → review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e42ec6285940
Enable readability-static-accessed-through-instance in the static analysis r=andi
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•