1422405 - geckoview_example is not respecting shutdown intent

Status: VERIFIED FIXED

(GeckoView :: General, defect)

Description

[Bob Clary [:bc] (inactive)]

Attachment: steps to reproduce

Autophone is having problems shutting down geckoview_example cleanly using the shutdown intent. This causes the geckoview_example tests to run much longer and possibly introduces noise since I have to wait 10 seconds before I force-stop it.

I thought we had this working after bug 1368701 but checking a geckoview_example from 2017-07-08 doesn't appear to work when attempting similar std.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Eugen please take a look.

Comment 2

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1422405-1.0-Add-shutdown-intent-for-geckoview_ex.patch

Looks like I've never landed patch 2 from bug 1368701, sorry about that.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8934685 [details] [diff] [review]
0001-Bug-1422405-1.0-Add-shutdown-intent-for-geckoview_ex.patch

Review of attachment 8934685 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/geckoview_example/src/main/java/org/mozilla/geckoview_example/GeckoViewActivity.java
@@ +114,5 @@
> +
> +        if (ACTION_SHUTDOWN.equals(intent.getAction())) {
> +            mKillProcessOnDestroy = true;
> +            GeckoThread.forceQuit();
> +            mGeckoView.onDetachedFromWindow();

We should let Android call `onDetachedFromWindow` instead of calling it ourselves.

Comment 4

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1422405-1.1-Add-shutdown-intent-for-geckoview_ex.patch

Addressed comments.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a466956afa4e
[1.1] Add shutdown intent for geckoview_example. r=jchen

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a466956afa4e

Comment 7

[Bob Clary [:bc] (inactive)]

Confirmed. This cut the run time for s1s2geckoview from 10 to 5 minutes. Thanks!