1422432 - Improve or remove PrintJSStack()

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement, P3)

Description

[Andrew McCreight [:mccr8]]

(In reply to Blake Kaplan (:mrbkap) from comment #10)
> (In reply to Andrew McCreight [:mccr8] from comment #7)
> > I changed the return value for the failure case to return the string instead
> > of printing it. I also had to change the return type to const char *.
> 
> At this point we should probably either add a comment that this function is
> intended to leak the return value or a comment to be clear that this
> function is only intended to be used from a debugger. Even in debug-only
> stuff, it makes me nervous to see a function returning both malloc'd memory
> and string literals.
> 
> Alternatively, maybe strdup the constant string?

Yeah, it is kind of gross. I could just delete it and see if anybody complains. Or move it to XPCDebug.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

I vote for deleting it.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1422432 - Remove PrintJSStack().

Review commit: https://reviewboard.mozilla.org/r/204744/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204744/

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8933827 [details]
Bug 1422432 - Remove PrintJSStack().

https://reviewboard.mozilla.org/r/204744/#review210802

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a68d5f4b11c0
Remove PrintJSStack(). r=mrbkap

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/a68d5f4b11c0