1422584 - Crash in mozilla::dom::ClientSource::DocShellExecutionReady

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-a5f57119-40dc-48ec-bab3-f39620171202.
=============================================================

Seen while looking at nightly crash stats: http://bit.ly/2jGtG5i. Crashes started using 20171202100103. Possible regression range based on Build ID: 
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a21f4e2ce5186e2dc9ee411b07e9348866b4ef30&tochange=de1f7a92e8726bdd365d4bbc5e65eaa369fbc20a
Top 10 frames of crashing thread:

0 xul.dll mozilla::dom::ClientSource::DocShellExecutionReady dom/clients/manager/ClientSource.cpp:225
1 xul.dll nsDocShell::MaybeCreateInitialClientSource docshell/base/nsDocShell.cpp:3448
2 xul.dll nsDocShell::DoChannelLoad docshell/base/nsDocShell.cpp:11861
3 xul.dll nsDocShell::DoURILoad docshell/base/nsDocShell.cpp:11657
4 xul.dll nsDocShell::InternalLoad docshell/base/nsDocShell.cpp:10989
5 xul.dll nsDocShell::LoadURI docshell/base/nsDocShell.cpp:1623
6 xul.dll nsFrameLoader::ReallyStartLoadingInternal dom/base/nsFrameLoader.cpp:998
7 xul.dll nsDocument::MaybeInitializeFinalizeFrameLoaders dom/base/nsDocument.cpp:7324
8 xul.dll mozilla::dom::XULDocument::DoneWalking dom/xul/XULDocument.cpp:3036
9 xul.dll mozilla::dom::XULDocument::ResumeWalk dom/xul/XULDocument.cpp:2970

=============================================================

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

This is code I added.  I'll look on Monday.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

I think we just need a nullptr check.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Handle nullptr ClientSource in nsDocShell::MaybeCreateInitialClientSource(). r=baku

Andrea, this makes docshell handle the case where we fail to create an initial ClientSource.  This can happen if the IPC actors are being torn down for shutdown, etc.

Comment 4

[Andrea Marchesini [:baku]]

Comment on attachment 8934199 [details] [diff] [review]
Handle nullptr ClientSource in nsDocShell::MaybeCreateInitialClientSource(). r=baku

Review of attachment 8934199 [details] [diff] [review]:
-----------------------------------------------------------------

::: docshell/base/nsDocShell.cpp
@@ +3440,5 @@
>    mInitialClientSource =
>      ClientManager::CreateSource(ClientType::Window,
>                                  win->EventTargetFor(TaskCategory::Other),
>                                  principal);
> +  if (!mInitialClientSource) {

NS_WARN_IF ?

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Handle nullptr ClientSource in nsDocShell::MaybeCreateInitialClientSource(). r=baku

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e18c1ff30e40
Handle nullptr ClientSource in nsDocShell::MaybeCreateInitialClientSource(). r=baku

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/e18c1ff30e40

Comment 8

[Calixte Denizet (:calixte)]

No more crashes in nightly 59 since the patch landed.