1422636 - stylo: Gecko_Namespace appears on stylo-chrome profiles.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Emilio Cobos Álvarez [:emilio]]

Unsurprisingly, because of XUL.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

There's no function called Gecko_GetNamespace. You mean Gecko_Namespace?

Comment 2

[Emilio Cobos Álvarez [:emilio]]

(In reply to Xidorn Quan [:xidorn] UTC-6 (less responsive Nov 5 ~ Dec 16) from comment #1)
> There's no function called Gecko_GetNamespace. You mean Gecko_Namespace?

Yes, short-term memory, whoops :)

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

So this function counts for 2.2ms in my profile, which isn't really a lot.

It is inlineable, though. We just need to have bindgen generate nsContentUtils and do some array accessing.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1422636: Inline Gecko_Namespace.

Review commit: https://reviewboard.mozilla.org/r/204952/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204952/

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8934023 [details]
Bug 1422636: Inline Gecko_Namespace.

https://reviewboard.mozilla.org/r/204952/#review210392

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6d7914cfbbd
Inline Gecko_Namespace. r=xidorn

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e6d7914cfbbd