1422662 - Move BaseMediaResource::Close() into MediaResource class

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

For the GeckoMedia project, I need to be able to shutdown an abstract MediaResource, so I would like to move BaseMediaResource::Close() up the inheritance hierarchy into MediaResource.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1422662 - Move BaseMediaResource::Close() into MediaResource class.

For the project to export Gecko's media stack and import it into Servo,
I need a way to shutdown an abstract MediaResource. So I'd like to move
BaseMediaResource::Close() up into MediaResource class.

Review commit: https://reviewboard.mozilla.org/r/204980/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204980/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8934045 [details]
Bug 1422662 - Move BaseMediaResource::Close() into MediaResource class.

https://reviewboard.mozilla.org/r/204980/#review210464

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a2629417a47
Move BaseMediaResource::Close() into MediaResource class. r=jwwang

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8295eb601d27
Backed out changeset 7a2629417a47 for bustage r=backout on a CLOSED TREE

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8934045 [details]
Bug 1422662 - Move BaseMediaResource::Close() into MediaResource class.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/204980/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0fe153d0bc4a
Move BaseMediaResource::Close() into MediaResource class. r=jwwang

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/0fe153d0bc4a