1422671 - Add telemetry for login reputation service

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, enhancement, P2)

Description

[Dimi Lee [:dimi]]

We can start with recording the time and result for local whitelist

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1422671 - Add telemetry for login reputation service. datareview?francois

Review commit: https://reviewboard.mozilla.org/r/205046/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205046/

Comment 2

[Dimi Lee [:dimi]]

Attachment: request-bug1422671.md

Comment 3

[François Marier [:francois]]

Comment on attachment 8934096 [details]
Bug 1422671 - Add telemetry for login reputation service.  datareview?francois

https://reviewboard.mozilla.org/r/205046/#review212080

::: toolkit/components/reputationservice/LoginReputation.cpp:587
(Diff revision 1)
> +
>    RefPtr<LoginReputationService> self = this;
>  
>    mLoginWhitelist->QueryLoginWhitelist(aRequest->mParam)->Then(
>      GetCurrentThreadSerialEventTarget(), __func__,
> -    [self, aRequest](VerdictType aResolveValue) -> void {
> +    [self, aRequest, startTime](VerdictType aResolveValue) -> void {

Is that in milliseconds? If so, could you please rename it to `startTimeMs`?

We've had a few bugs in the past due to unit conversions :)

Comment 4

[François Marier [:francois]]

Comment on attachment 8934097 [details]
request-bug1422671.md

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, Histograms.json

2) Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Dimi Lee.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 1.

5) Is the data collection request for default-on or default-off?

Default on.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, permanent.

Comment 5

[Dimi Lee [:dimi]]

Comment on attachment 8934096 [details]
Bug 1422671 - Add telemetry for login reputation service.  datareview?francois

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/205046/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d8de88bfdf3
Add telemetry for login reputation service. r=francois datareview?francois

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/3d8de88bfdf3