Closed Bug 1422676 Opened 7 years ago Closed 7 years ago

small error in test_2d.fill.pattern.imageSmoothingEnabled.html

Categories

(Core :: Graphics: Canvas2D, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: heycam, Assigned: heycam)

Details

Attachments

(1 file)

The lines: ctx.fillStyle = "rgb(127, 127, 127);" in the test result in a CSS parser error, since the ';' is unexpected. Fixing this means the pixel values we want to check for are different, so instead let's just remove these statements and rely on the default solid black fill style that the test is actually using. (I noticed this working on bug 1420026.)
Assignee: nobody → cam
Status: NEW → ASSIGNED
Comment on attachment 8934064 [details] Bug 1422676 - Fix small CSS error in test_2d.fill.pattern.imageSmoothingEnabled.html. https://reviewboard.mozilla.org/r/205006/#review210470
Attachment #8934064 - Flags: review?(tlin) → review+
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c09b561dd202 Fix small CSS error in test_2d.fill.pattern.imageSmoothingEnabled.html. r=TYLin
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: