1422995 - Use waitForNextFrame in test_animations-dynamic-changes.html

Status: RESOLVED FIXED

(Core :: DOM: Animation, enhancement)

Description

[Hiroyuki Ikezoe (:hiro)]

A try [1] shows us a test case fails with the conformant Promise handling and performing micro task checkpoint in Animation tick.  The failure reason is that we call waitForFrame() [2] to advance the frame but actually it's not.   We should use waitForNextFrame() instead.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=683622b6bba07caec14c439a56aadd843b40f532&selectedJob=149497311
[2] https://hg.mozilla.org/mozilla-central/file/e19b017880c8/dom/animation/test/css-animations/file_animations-dynamic-changes.html#l29

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1422995 - Use waitForNextFrame() instead of waitForFrame() to make sure the next requestAnimationFrame callback happen.

With the conformant Promise handling (bug 1193394) and performaing micro task
checkpoint in Animation tick (bug 1416966), if we call waitForFrame() inside
the callback for Animation.ready.then it will still be done in the same refresh
driver's tick.

Review commit: https://reviewboard.mozilla.org/r/205252/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205252/

Comment 2

[Brian Birtles (:birtles)]

Comment on attachment 8934324 [details]
Bug 1422995 - Use waitForNextFrame() instead of waitForFrame() to make sure the next requestAnimationFrame callback happen.

https://reviewboard.mozilla.org/r/205252/#review210818

::: commit-message-4a160:3
(Diff revision 1)
> +Bug 1422995 - Use waitForNextFrame() instead of waitForFrame() to make sure the next requestAnimationFrame callback happen. r?birtles
> +
> +With the conformant Promise handling (bug 1193394) and performaing micro task

nit: s/performaing/performing/

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8934324 [details]
Bug 1422995 - Use waitForNextFrame() instead of waitForFrame() to make sure the next requestAnimationFrame callback happen.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/205252/diff/1-2/

Comment 4

[Hiroyuki Ikezoe (:hiro)]

A final try, it runs only on Linux64 and Android, but it should be fine.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb6d8630825c609ebabe868c5b76ddceb2db7879

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/793d2834b3e3
Use waitForNextFrame() instead of waitForFrame() to make sure the next requestAnimationFrame callback happen. r=birtles

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/793d2834b3e3