1423014 - l10n fixes - bump devedition; 5 locales-per-chunk

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, enhancement)

Description

[Aki Sasaki (not active)]

These are fixes from maple. These patches can land first, and will help us diff between central and maple.

Comment 1

[Aki Sasaki (not active)]

Attachment: bug 1423014 - fix l10n rstrip bug.

'win64-devedition-nightly'.rstrip('-nightly') gives us 'win64-deveditio'
Changing to a .replace() fixes this.

Review commit: https://reviewboard.mozilla.org/r/205300/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205300/

Comment 2

[Aki Sasaki (not active)]

Attachment: bug 1423014 - 5 locales per chunk.

We used to be at 5 locales per chunk, but I reduced it to 2 because we were timing out on signing. That appears to have been due to network issues; let's go back to 5 to reduce the number of tasks in the graph.

Review commit: https://reviewboard.mozilla.org/r/205302/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205302/

Comment 3

[Aki Sasaki (not active)]

Attachment: bug 1423014 - add devedition to l10n-changesets.

Review commit: https://reviewboard.mozilla.org/r/205304/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205304/

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 8934373 [details]
bug 1423014 - fix l10n rstrip bug.

https://reviewboard.mozilla.org/r/205300/#review210890

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 8934374 [details]
bug 1423014 - 5 locales per chunk.

https://reviewboard.mozilla.org/r/205302/#review210892

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 8934375 [details]
bug 1423014 - add devedition to l10n-changesets.

https://reviewboard.mozilla.org/r/205304/#review210894

I want an additional r+ from pike on this one... would any of your tooling break with deved products?

Comment 7

[Justin Wood (:Callek)]

Comment on attachment 8934375 [details]
bug 1423014 - add devedition to l10n-changesets.

From IRC, no need for Pike to review..

12:18 PM <Callek> Pike: ping --- can you give this a quick once over please https://bugzilla.mozilla.org/show_bug.cgi?id=1423014#c6
12:19 PM <Pike> Callek: I've looked, and couldn't really figure out what the impact is. For example, what's the impact of deved platforms on the nightly configs?
12:19 PM <Pike> I'm not using those files for anything, though
12:19 PM <Callek> Pike: I'm mostly concerned "does your tooling read this file"
12:19 PM <Callek> and if so, "would this hurt your tooling in any way"
12:19 PM <Pike> "no"
12:19 PM <Callek> ok, great thanks.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e83dfdaeb3f
fix l10n rstrip bug. r=Callek
https://hg.mozilla.org/integration/autoland/rev/f05c730d1de7
5 locales per chunk. r=Callek
https://hg.mozilla.org/integration/autoland/rev/b159a6ed52f7
add devedition to l10n-changesets. r=Callek

Comment 9

[Aki Sasaki (not active)]

Thanks!
Adding a leave-open keyword because we still have to bump puppet revs for l10n-bumper once this merges to central.

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5e83dfdaeb3f
https://hg.mozilla.org/mozilla-central/rev/f05c730d1de7
https://hg.mozilla.org/mozilla-central/rev/b159a6ed52f7

Comment 11

[Axel Hecht [:Pike]]

Some unscientific time-keeping from today's nightly: This added some 15 minutes between N and Ns to the job times

5000-5263 tasks before (that fluctuates quite a bit? reruns?) to ~4850 on the latest nightly. The impact on the taskgraph size isn't all that big 'cause all the post-Ns tasks are per locale.

Comment 12

[Aki Sasaki (not active)]

Good to know, thank you.
We're currently planning to chunk up post-Ns tasks, since we're hitting performance issues with the task group inspector.

Comment 13

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.