Closed
Bug 1423053
Opened 7 years ago
Closed 6 years ago
Support accepting a payment request from the UI (with dummy data)
Categories
(Firefox :: WebPayments UI, enhancement, P1)
Firefox
WebPayments UI
Tracking
()
RESOLVED
FIXED
Firefox 59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: MattN, Assigned: MattN)
Details
Attachments
(2 files)
When the user clicks Pay, tell the DOM code and pass along the minimal dummy data required by the API so that the dialog can close. Later bugs will actually allow the user to pick their CC and address. This will facilitate more manual testing of the common flow.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Priority: -- → P1
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 5•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8935224 [details] Bug 1423053 - Close the PaymentRequest UI when complete is called. https://reviewboard.mozilla.org/r/206100/#review214024 ::: toolkit/components/payments/paymentUIService.js:76 (Diff revision 2) > > completePayment(requestId) { > this.log.debug("completePayment:", requestId); > let completeResponse = Cc["@mozilla.org/dom/payments/payment-complete-action-response;1"] > .createInstance(Ci.nsIPaymentCompleteActionResponse); > - completeResponse.init(requestId, Ci.nsIPaymentActionResponse.COMPLTETE_SUCCEEDED); > + completeResponse.init(requestId, Ci.nsIPaymentActionResponse.COMPLETE_SUCCEEDED); Should we be using COMPLETE_FAILED here if the dialog isn't found?
Attachment #8935224 -
Flags: review?(jaws) → review+
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
||
Comment 8•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8935225 [details] Bug 1423053 - Support accepting a payment request from the UI (with dummy data). https://reviewboard.mozilla.org/r/206102/#review214232 ::: toolkit/components/payments/test/unit/test_response_creation.js:89 (Diff revision 2) > + addressLines: [ > + "123 Sesame Street", > + "P.O. Box ABC", > + ], > + region: "ON", > + city: "Delhi", +1
Attachment #8935225 -
Flags: review?(jaws) → review+
| Comment hidden (mozreview-request) |
|
||
Comment 10•6 years ago
|
||
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/04fc5cd20916 Close the PaymentRequest UI when complete is called. r=jaws https://hg.mozilla.org/integration/autoland/rev/131e43affb8f Support accepting a payment request from the UI (with dummy data). r=jaws
|
||
Comment 11•6 years ago
|
||
Backed out for ESlint failure on /toolkit/components/payments/content/PaymentDialog.js: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=cd534162b8f47e02dbb10f6a23e2b9d72d4deac2&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success https://treeherder.mozilla.org/logviewer.html#?job_id=152731361&repo=autoland
Flags: needinfo?(MattN+bmo)
| Comment hidden (mozreview-request) |
|
|
||
Comment 13•6 years ago
|
||
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/6604f8508dd9 Close the PaymentRequest UI when complete is called. r=jaws https://hg.mozilla.org/integration/autoland/rev/a25d929f127e Support accepting a payment request from the UI (with dummy data). r=jaws
|
|
Assignee | |
Updated•6 years ago
|
Flags: needinfo?(MattN+bmo)
|
||
Comment 14•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6604f8508dd9 https://hg.mozilla.org/mozilla-central/rev/a25d929f127e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
||
Updated•6 years ago
|
Product: Toolkit → Firefox
Target Milestone: mozilla59 → Firefox 59
You need to log in
before you can comment on or make changes to this bug.
Description
•