Closed Bug 1423201 Opened 3 years ago Closed 2 years ago
convert uses of "defer" to "new Promise" - server/tests/mochitest directory
5.06 KB, patch
|Details | Diff | Splinter Review|
46 bytes, text/x-phabricator-request
|Details | Review|
No description provided.
(In reply to shreya [:shr7] from comment #1) > Created attachment 8934856 [details] [diff] [review] > convert uses of defer to new Promise - server/tests/mochitest directory shreya, so sorry we missed your patch ! If you have the time, and are willing to move it forward, could you try to rebase it against an up-to-date mozilla-central repository ? If you don't have the time/don't want to do it, do you mind if someone else takes over ? Thanks a lot and sorry again !
Hey Nicolas, I can work on this if shreya can't get to it.
Sure, let's do that for now since shreya did not answered yet. If in the meantime they do answer, please understand that I will give them their patch the priority :)
Assignee: shreya.chandra96 → reeisesean
(In reply to Nicolas Chevobbe [:nchevobbe] from comment #4) > Sure, let's do that for now since shreya did not answered yet. > If in the meantime they do answer, please understand that I will give them > their patch the priority :) For sure, no worries. Thanks.
Functions using 'defer' for promises are being switched to the 'new Promise' syntax. This is for changes in devtools/server/tests/mochitest.
The patch includes fixes for linting errors shown in try build as well.
Comment on attachment 9011387 [details] Bug 1423201 - Changed uses of defer to new Promise in devtools/server/tests/mochitest r?nchevobbe Nicolas Chevobbe [:nchevobbe] has approved the revision.
Attachment #9011387 - Flags: review+
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/816d356e8fc7 Changed uses of defer to new Promise in devtools/server/tests/mochitest r=nchevobbe
You need to log in before you can comment on or make changes to this bug.