1423201 - convert uses of "defer" to "new Promise" - server/tests/mochitest directory

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P4)

Comment 1

[shreya [:shr7]]

Attachment: convert uses of defer to new Promise - server/tests/mochitest directory

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

(In reply to shreya [:shr7] from comment #1)
> Created attachment 8934856 [details] [diff] [review]
> convert uses of defer to new Promise - server/tests/mochitest directory

shreya, so sorry we missed your patch !
If you have the time, and are willing to move it forward, could you try to rebase it against an up-to-date mozilla-central repository ?
If you don't have the time/don't want to do it, do you mind if someone else takes over ?

Thanks a lot and sorry again !

Comment 3

[Sean Reeise [:sreeise]]

Hey Nicolas, I can work on this if shreya can't get to it.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Sure, let's do that for now since shreya did not answered yet.
If in the meantime they do answer, please understand that I will give them their patch the priority :)

Comment 5

[Sean Reeise [:sreeise]]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #4)
> Sure, let's do that for now since shreya did not answered yet.
> If in the meantime they do answer, please understand that I will give them
> their patch the priority :)

For sure, no worries. Thanks.

Comment 6

[Sean Reeise [:sreeise]]

Attachment: Bug 1423201 - Changed uses of defer to new Promise in devtools/server/tests/mochitest r?nchevobbe

Functions using 'defer' for promises are being switched to the 'new Promise' syntax. This is for changes in devtools/server/tests/mochitest.

Comment 7

[Sean Reeise [:sreeise]]

try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=286591a2b99aa4b3ccbb4f20e385ad68378ce658

Comment 8

[Sean Reeise [:sreeise]]

The patch includes fixes for linting errors shown in try build as well.

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9011387 [details]
Bug 1423201 - Changed uses of defer to new Promise in devtools/server/tests/mochitest r?nchevobbe

Nicolas Chevobbe [:nchevobbe] has approved the revision.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/816d356e8fc7
Changed uses of defer to new Promise in devtools/server/tests/mochitest r=nchevobbe

Comment 11

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/816d356e8fc7

Comment 12

[Nicolas Chevobbe [:nchevobbe]]

clearing flag