Closed
Bug 1423231
Opened 8 years ago
Closed 8 years ago
Remove unnecessary BaseShape::getUnowned calls from putAccessorProperty/putDataProperty
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
Details
Attachments
(1 file)
|
2.81 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
We call BaseShape::getUnowned here, for instance: https://searchfox.org/mozilla-central/rev/ba2b0cf4d16711d37d4bf4d267b187c9a27f6638/js/src/vm/Shape.cpp#891
But it should be fine to just use the BaseShape* we already got here: https://searchfox.org/mozilla-central/rev/ba2b0cf4d16711d37d4bf4d267b187c9a27f6638/js/src/vm/Shape.cpp#842-848
I noticed this while working on a patch where this actually caused a bug, but we might as well fix this separately.
Attachment #8934563 -
Flags: review?(bhackett1024)
|
||
Updated•8 years ago
|
Attachment #8934563 -
Flags: review?(bhackett1024) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e1f3dfd40107
Remove redundant BaseShape::getUnowned calls from putAccessorProperty/putDataProperty. r=bhackett
|
||
Comment 2•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•