1423394 - 1.3GB GPU-process memory leak

Status: RESOLVED DUPLICATE of bug 1386177

(Core :: Graphics, defect, P3)

Description

[Qwerty]

Attachment: memory-report.json.gz

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171128222554

Steps to reproduce:

I used Firefox for 8 hours, last 1-2 hours I opened 400-500 tabs (trying to fix favicons in my session to mitigate bug 1423389), closed about 200. I understand that main and content processes memory usage will grow, but I noticed that for some reasons gpu-process grew the most and don't shrink even when minimizing via about:memory.
I hope that anonymized memory report would help.


Actual results:

GPU-process grew to 1.3 gb of working set (Process Explorer).


Expected results:

GPU-process shouldn't suffer from number of tabs or should GCing normally.

Comment 1

[Eric Rahm [:erahm]]

Milan is there someone who can take a look at this? It's a 1.3GB leak.

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

I'm sure we'd have noticed at 1.3GB leak, but let's see.

Comment 3

[Bas Schouten (:bas.schouten)]

(In reply to Milan Sreckovic [:milan] from comment #2)
> I'm sure we'd have noticed at 1.3GB leak, but let's see.

I somewhat doubt this is a leak.. in the about:memory report we also don't see memory usage anything of the sorts inside the GPU process, I wonder if this is something about what Process Explorer reports as the 'working set', I wonder what it was reporting as the Private Working Set in this situation.

Comment 4

[Bas Schouten (:bas.schouten)]

(In reply to Bas Schouten (:bas.schouten) from comment #3)
> (In reply to Milan Sreckovic [:milan] from comment #2)
> > I'm sure we'd have noticed at 1.3GB leak, but let's see.
> 
> I somewhat doubt this is a leak.. in the about:memory report we also don't
> see memory usage anything of the sorts inside the GPU process, I wonder if
> this is something about what Process Explorer reports as the 'working set',
> I wonder what it was reporting as the Private Working Set in this situation.

Ah, more carefully looking at it, under 'resident' it does report 1.3 GB, this is memory simply -mapped- by the GPU process (or one of the DLLs), not owned, I'm guessing this is something internal to DirectX or the Graphics drivers, which is shared with the OS. I somewhat doubt there is something we can do about it, our own counters suggests we're not keeping any texture objects on our side alive. It's possible the OS is just lazily clearing these as it doesn't require the memory, although it's sort of unexpected to eat that much into our address space, it's also quite fragmented (although I guess in a 64-bit process it hardly matters). It's possible we're leaking some DX object, but we'd expect to have noticed somewhere else and it seems unlikely as we don't handle their refcounts explicitly.

Of course it's also possible the graphics drivers have a leak internally.

Comment 5

[Qwerty]

Attachment: Process Explorer screen

(In reply to Bas Schouten (:bas.schouten) from comment #3)
> (In reply to Milan Sreckovic [:milan] from comment #2)
> I wonder what it was reporting as the Private Working Set in this situation.

I found screen. Private Bytes column for gpu-process was 124 820 K.

Comment 6

[Eric Rahm [:erahm]]

Duping over to 1425718.