1423502 - Clean up leftover files under netmonitor/src/*

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Ricky Chien [:rickychien] (inactive)]

Bug 1336382 and bug 1362059 are closed due to https://bugzilla.mozilla.org/show_bug.cgi?id=1336382#c2. There are some leftover files under src folder, and they have to be arranged to somewhere.

This is clean-up and I'd propose to create a src/widgets directory for accommodating RequestListContextMenu.js & RequestListHeaderContextMenu.js & WaterfallBackground.js since they don't belong react component but act as part of UI. (e.g. drawing waterfall vertical line, constructing contextmenu.)

request-list-tooltip.js is only used once and small enough to merge into RequestListContent.js itself, so I'll merge that into it.

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1423502 - Clean up leftover files under netmonitor/src/*

Review commit: https://reviewboard.mozilla.org/r/205854/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205854/

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8934924 [details]
Bug 1423502 - Clean up leftover files under netmonitor/src/*

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/205854/diff/1-2/

Comment 3

[Ricky Chien [:rickychien] (inactive)]

If you'd like to test the patch, please apply the patch based on bug 1418927 or using `hg pull` command from mozreview-board.

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8934924 [details]
Bug 1423502 - Clean up leftover files under netmonitor/src/*

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/205854/diff/2-3/

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8934924 [details]
Bug 1423502 - Clean up leftover files under netmonitor/src/*

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/205854/diff/3-4/

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8934924 [details]
Bug 1423502 - Clean up leftover files under netmonitor/src/*

https://reviewboard.mozilla.org/r/205854/#review211818

Yep, I like the new directory structure.

R+ assuming try is green and my inline comment is resolved.

Thanks Ricky!
Honza

::: devtools/client/netmonitor/src/components/RequestListContent.js:34
(Diff revision 4)
>  
>  const { div } = dom;
>  
>  // Tooltip show / hide delay in ms
>  const REQUESTS_TOOLTIP_TOGGLE_DELAY = 500;
> +// Tooltip image maxmium dimension in px

typo: maxmium -> maximum

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8934924 [details]
Bug 1423502 - Clean up leftover files under netmonitor/src/*

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/205854/diff/4-5/

Comment 8

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8934924 [details]
Bug 1423502 - Clean up leftover files under netmonitor/src/*

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/205854/diff/5-6/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35702424bcfc
Clean up leftover files under netmonitor/src/* r=Honza

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/35702424bcfc