Closed Bug 1423502 Opened 7 years ago Closed 7 years ago

Clean up leftover files under netmonitor/src/*

Categories

(DevTools :: Netmonitor, defect, P3)

Product:
DevTools
Component:
Netmonitor
Type:
defect

Tracking

(firefox59 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: rickychien, Assigned: rickychien)

References

Details

Attachments

(1 file)

Bug 1423502 - Clean up leftover files under netmonitor/src/*
59 bytes, text/x-review-board-request
Honza
: review+
Details 
Bug 1336382 and bug 1362059 are closed due to https://bugzilla.mozilla.org/show_bug.cgi?id=1336382#c2. There are some leftover files under src folder, and they have to be arranged to somewhere.

This is clean-up and I'd propose to create a src/widgets directory for accommodating RequestListContextMenu.js & RequestListHeaderContextMenu.js & WaterfallBackground.js since they don't belong react component but act as part of UI. (e.g. drawing waterfall vertical line, constructing contextmenu.)

request-list-tooltip.js is only used once and small enough to merge into RequestListContent.js itself, so I'll merge that into it.
Summary: Implement RequestListHeaderContextMenu React component → Clean up leftover files under netmonitor/src/*
If you'd like to test the patch, please apply the patch based on bug 1418927 or using `hg pull` command from mozreview-board.
Comment on attachment 8934924 [details]
Bug 1423502 - Clean up leftover files under netmonitor/src/*

https://reviewboard.mozilla.org/r/205854/#review211818

Yep, I like the new directory structure.

R+ assuming try is green and my inline comment is resolved.

Thanks Ricky!
Honza

::: devtools/client/netmonitor/src/components/RequestListContent.js:34
(Diff revision 4)
>  
>  const { div } = dom;
>  
>  // Tooltip show / hide delay in ms
>  const REQUESTS_TOOLTIP_TOGGLE_DELAY = 500;
> +// Tooltip image maxmium dimension in px

typo: maxmium -> maximum
Attachment #8934924 - Flags: review?(odvarko) → review+
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/35702424bcfc
Clean up leftover files under netmonitor/src/* r=Honza
https://hg.mozilla.org/mozilla-central/rev/35702424bcfc
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: