IDL: remove [PrimaryGlobal]
Categories
(Core :: DOM: Bindings (WebIDL), enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: annevk, Assigned: bzbarsky)
References
Details
Attachments
(3 files)
See https://github.com/w3c/web-platform-tests/pull/8585 for test changes. Background and other specification changes linked from https://github.com/heycam/webidl/issues/365.
Assignee | ||
Comment 2•7 years ago
|
||
This probably depends on 1414372, though I'm not sure what the end result was with the exposure sets of mixins, exactly. Certainly we want to get to a point where our internal validation knows which things are interfaces and which mixins, because the former needs to enforce an exposure set and the latter needs to not enforce it.
Updated•7 years ago
|
Reporter | ||
Updated•7 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
There are no callers who want this. They all filter out external interfaces in various ways; we might as well do it up front.
Assignee | ||
Comment 5•5 years ago
|
||
For review purposes, the important changes are in dom/bindings/Configuration.py
and dom/bindings/parser.
The changes to the IDL files were done by running these in dom/webidl
and dom/bindings/test:
perl -pi -e 's/^interface ([A-Za-z0-9_]+)($| [:{])/[Exposed=Window]\ninterface \1\2/' *.webidl
perl -pi -e 'BEGIN { $/ = undef; } s/[HTMLConstructor]\n[Exposed=Window]/[HTMLConstructor,\n Exposed=Window]/g' *.webidl
perl -pi -e 'BEGIN { $/ = undef; } s/[NoInterfaceObject]\n[Exposed=Window]/[NoInterfaceObject,\n Exposed=Window]/g' *.webidl
perl -pi -e 'BEGIN { $/ = undef; } s/[ChromeOnly]\n[Exposed=Window]/[ChromeOnly,\n Exposed=Window]/g' *.webidl
And running this in dom/chrome-webidl:
perl -pi -e 'BEGIN { $/ = undef; } s/[ChromeOnly]\ninterface/[ChromeOnly, Exposed=Window]\ninterface/g' *.webidl
and then fixing all the resulting parser failures. I then verified that the
generated code is the same as before this change.
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6a6f61b05da7 part 1. Change Configuration.getDescriptors to never return external interface descriptors. r=edgar https://hg.mozilla.org/integration/autoland/rev/7cdac5476150 part 2. Change external interfaces to not have exposure sets. r=edgar https://hg.mozilla.org/integration/autoland/rev/2416d17d33c1 part 3. Remove [PrimaryGlobal] and require explicit [Exposed] annotations on everything. r=edgar
Comment 7•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6a6f61b05da7
https://hg.mozilla.org/mozilla-central/rev/7cdac5476150
https://hg.mozilla.org/mozilla-central/rev/2416d17d33c1
Description
•