1423563 - [Stylo-chrome] Show connection details on Nighlty 59 doesn't look the same as on Firefox 57

Status: RESOLVED INVALID

(Core :: CSS Parsing and Computation, defect)

Description

[Hani Yacoub, Desktop QA]

Attachment: N59 - connection details.png

[Affected versions]: 
Nightly 59.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.

[Preconditions]:
1. Go to about:config
2. "layout.css.servo.enabled" pref's default value is already TRUE
3. Set “layout.css.servo.chrome.enabled” to TRUE
4. Restart Firefox for the "layout.css.servo.chrome.enabled" pref change to take effect

[Steps to reproduce]:
1. Launch Firefox and go to "http://permission.site/".
2. Click on "Notifications".
3. Click on the drop down and then on "Never Allow".
4. Click on "Show site information".
5. Click on "Show connection details".

[Expected result]:
Show connection details on Nighlty 59 should look the same as on Firefox 57.

[Actual result]:
Show connection details on Nighlty 59 doesn't look the same as on Firefox 57.

Comment 1

[Hani Yacoub, Desktop QA]

Attachment: 57 - Connection details.png

Comment 2

[Sören Hentzschel]

(In reply to Hani Yacoub from comment #0)
> [Expected result]:
> Show connection details on Nighlty 59 should look the same as on Firefox 57.

No, this is not the expected result because the design of the site identity popup has changed since then. Please compare layout.css.servo.chrome.enabled: false on Firefox 59 Nightly with layout.css.servo.chrome.enabled: true on Firefox 59 Nightly and not Firefox 57 vs. Firefox 59. ;)

Comment 3

[Hani Yacoub, Desktop QA]

From a previous e-mail received from Chris he mentioned that "we want to compare Nightly 59's Stylo-chrome with Firefox 57's UI. Ensuring that the UI features *look exactly the same* as Firefox 57 is the most important part of this testing".

Chris could you please take a look at this?

Comment 4

[Chris Peterson [:cpeterson]]

Hani, my suggestion to compare Firefox 59 with stylo-chrome to Firefox 57 was a bad idea. I didn't realize how many front-end UI changes, like this permission drop down menu, were made since Firefox 57. Sorry!

Ovidiu pinged me on Slack and we concluded that we should not use Firefox 57 for comparison. We should just compare Firefox 59 with the "layout.css.servo.chrome.enabled" = true and = false. You will need to restart the browser after changing the pref value.