Firefox assist app: if Firefox is in tab view, switch to the newly opened tab

RESOLVED FIXED in Firefox 59

Status

()

Firefox for Android
General
P3
normal
RESOLVED FIXED
2 months ago
13 days ago

People

(Reporter: Mark, Assigned: JanH)

Tracking

Firefox 59
Firefox 59
All
Android
Points:
---

Firefox Tracking Flags

(firefox57 unaffected, firefox58 unaffected, firefox59 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 months ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_1) AppleWebKit/604.3.5 (KHTML, like Gecko) Version/11.0.1 Safari/604.3.5

Steps to reproduce:

Follow on from bug 1413739
Long pressing the home button results in Firefox being called (Assist app) with a new tab.

But...

If Firefox was previously left with the tabs tray open, invoking the assist button just shows the tabs tray.
Firefox should switch to the newly opened tab, even if the tab tray was opened.

See also bug 1350994

Comment 1

19 days ago
Hi Jan
Please help advise. Thanks!
Flags: needinfo?(jh+bugzilla)

Updated

19 days ago
Priority: -- → P3
(Assignee)

Comment 2

18 days ago
Hmm, in theory it's just another variety of bug 1350994, although the fact that we open edit mode causes some additional weirdness, because no matter what tab you select from the tabs tray, you end up in edit mode and when you then leave edit mode, in the newly opened assist intent tab. I'll try and see if there's some easy way of doing this without waiting for the rest of bug 1350994.
(Assignee)

Updated

17 days ago
Assignee: nobody → jh+bugzilla
Status: UNCONFIRMED → NEW
status-firefox57: --- → unaffected
status-firefox58: --- → unaffected
status-firefox59: --- → affected
Ever confirmed: true
Flags: needinfo?(jh+bugzilla)
OS: Unspecified → Android
Hardware: Unspecified → All
Version: 57 Branch → Firefox 59
Comment hidden (mozreview-request)

Comment 4

14 days ago
mozreview-review
Comment on attachment 8940285 [details]
Bug 1423566 - Hide tabs tray when receiving an Assist App intent.

https://reviewboard.mozilla.org/r/210556/#review216546
Attachment #8940285 - Flags: review?(cnevinchen) → review+

Comment 5

14 days ago
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/2837beb13320
Hide tabs tray when receiving an Assist App intent. r=nechen

Comment 6

14 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2837beb13320
Status: NEW → RESOLVED
Last Resolved: 14 days ago
status-firefox59: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
(Reporter)

Comment 7

13 days ago
Fixed for me too.

Thanks for adding this Assist feature so quickly. Now I have one-touch access to the Awesomescreen which is Awesome.

Now, for an encore, how about pull-to-reload? I know it's been subject of a Big Mozilla Debate for years ;)
You need to log in before you can comment on or make changes to this bug.