1423566 - Firefox assist app: if Firefox is in tab view, switch to the newly opened tab

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Mark]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_1) AppleWebKit/604.3.5 (KHTML, like Gecko) Version/11.0.1 Safari/604.3.5

Steps to reproduce:

Follow on from bug 1413739
Long pressing the home button results in Firefox being called (Assist app) with a new tab.

But...

If Firefox was previously left with the tabs tray open, invoking the assist button just shows the tabs tray.
Firefox should switch to the newly opened tab, even if the tab tray was opened.

See also bug 1350994

Comment 1

[Nevin Chen(Not active on Bugzilla)]

Hi Jan
Please help advise. Thanks!

Comment 2

[Jan Henning [:JanH]]

Hmm, in theory it's just another variety of bug 1350994, although the fact that we open edit mode causes some additional weirdness, because no matter what tab you select from the tabs tray, you end up in edit mode and when you then leave edit mode, in the newly opened assist intent tab. I'll try and see if there's some easy way of doing this without waiting for the rest of bug 1350994.

Comment 3

[Jan Henning [:JanH]]

Attachment: Bug 1423566 - Hide tabs tray when receiving an Assist App intent.

We're still somewhat undecided on how to exactly handle external intents
arriving while the tabs tray is open, however in the case of Assist App intents
- opening a new tab in editing mode while the tabs tray remains open causes some
  weird behaviour (the keyboard appears in front of the tabs tray and no matter
  which tab is selected on the tabs tray, you first enter editing mode and then
  always end up in the tab opened by the Assist App intent)
- the goal of our Assist App intent handling is to allow the user to enter a
  search query or an address into the URL bar

hence we should hide the tabs tray (if open) when handling such an intent.

Review commit: https://reviewboard.mozilla.org/r/210556/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210556/

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8940285 [details]
Bug 1423566 - Hide tabs tray when receiving an Assist App intent.

https://reviewboard.mozilla.org/r/210556/#review216546

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2837beb13320
Hide tabs tray when receiving an Assist App intent. r=nechen

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2837beb13320

Comment 7

[Mark]

Fixed for me too.

Thanks for adding this Assist feature so quickly. Now I have one-touch access to the Awesomescreen which is Awesome.

Now, for an encore, how about pull-to-reload? I know it's been subject of a Big Mozilla Debate for years ;)