Closed Bug 1423567 Opened 2 years ago Closed 2 years ago

Use BaseRect methods instead of directly member variables in image/

Categories

(Core :: Graphics, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: milan, Assigned: milan)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

No description provided.
Assignee: nobody → milan
Blocks: 1386277
Priority: -- → P3
Whiteboard: [gfx-noted]
Comment on attachment 8934963 [details]
Bug 1423567: Use BaseRect access methods instead of member variables in image/

https://reviewboard.mozilla.org/r/205910/#review211444

::: image/FrameAnimator.cpp:995
(Diff revision 1)
>      if (!src) {
>        return NS_ERROR_OUT_OF_MEMORY;
>      }
>      pixman_image_t* dst =
>        pixman_image_create_bits(PIXMAN_a8r8g8b8,
> -                               aDstRect.Width(),
> +                               aSstRect.Width(),

nit: typo (aSstRect)
Attachment #8934963 - Flags: review?(aosmond) → review+
Blocks: 1423919
No longer blocks: 1386277
Pushed by msreckovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/570db0492055
Use BaseRect access methods instead of member variables in image/ r=aosmond
https://hg.mozilla.org/mozilla-central/rev/570db0492055
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.