1423567 - Use BaseRect methods instead of directly member variables in image/

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P3)

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Bug 1423567: Use BaseRect access methods instead of member variables in image/

Review commit: https://reviewboard.mozilla.org/r/205910/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205910/

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 8934963 [details]
Bug 1423567: Use BaseRect access methods instead of member variables in image/

https://reviewboard.mozilla.org/r/205910/#review211444

::: image/FrameAnimator.cpp:995
(Diff revision 1)
>      if (!src) {
>        return NS_ERROR_OUT_OF_MEMORY;
>      }
>      pixman_image_t* dst =
>        pixman_image_create_bits(PIXMAN_a8r8g8b8,
> -                               aDstRect.Width(),
> +                               aSstRect.Width(),

nit: typo (aSstRect)

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8934963 [details]
Bug 1423567: Use BaseRect access methods instead of member variables in image/

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/205910/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/570db0492055
Use BaseRect access methods instead of member variables in image/ r=aosmond

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/570db0492055