1423618 - requestedLocales is en-US for repackaged builds

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement, P2)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

In bug 1414390 we removed the firefox-l10n.js overrides and established a new `intl.locale.requested` pref as an override of the default setup - meaning, if it's not present, take the default locale.

This is exactly what it should do, except that we still set it by hand in `browser/app/profile/firefox.js` to en-US and then on repackage this file doesn't get updated.

Cleanest solution is to remove the pref from there and let LocaleService pick the default locale in the default scenario.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1423618 - Remove hardcoded build time intl.locale.requested.

The new heuristic for requested locales in LocaleService makes the
intl.locale.requested an override to the default locale.

This patch removes the hardcoded setting of the pref to the build time locale,
allowing LocaleService to pick the default locale by default.

Review commit: https://reviewboard.mozilla.org/r/205938/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205938/

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 8935096 [details]
Bug 1423618 - Remove hardcoded build time intl.locale.requested.

https://reviewboard.mozilla.org/r/205938/#review211560

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e82fc38fe40d
Remove hardcoded build time intl.locale.requested. r=Pike

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e82fc38fe40d