1423644 - Don't create the nsAppShell hidden message window, when not using native event processing.

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect, P1)

Comment 1

[Bob Owen (:bobowen) (PTO until 5th Jan)]

Attachment: Don't create the nsAppShell hidden message window, when not using native event processing

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 8935044 [details] [diff] [review]
Don't create the nsAppShell hidden message window, when not using native event processing

Review of attachment 8935044 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/nsAppShell.cpp
@@ +172,5 @@
>    NS_ASSERTION(sTaskbarButtonCreatedMsg, "Could not register taskbar button creation message");
>  
> +  // The hidden message window is used for interrupting the processing of native
> +  // events, so that we can process gecko events.
> +  // Therefore, we only need it if we are processing native events.

nit - odd wrapping here, tighten this comment up please.

Comment 3

[Bob Owen (:bobowen) (PTO until 5th Jan)]

Thanks Jim, I'll remove the break on the full stop then.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f0d236c8a9a473184bef516edb62e1ff74f3870

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/56b0acc6e0af
Don't create the nsAppShell hidden message window, when not using native event processing. r=jimm

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/56b0acc6e0af