Closed Bug 1423669 Opened 8 years ago Closed 8 years ago

Debug build with gfx.webrender.hit-test=true crashes on startup

Categories

(Core :: Graphics: WebRender, enhancement, P1)

Other Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [wr-mvp] [gfx-noted])

Attachments

(1 file)

We do the hit-test from APZ on the APZ controller thread, whereas WebRenderAPI has refcounting only on the compositor thread. So the call at [1] crashes. I guess I never ran this pref in debug mode before :/ [1] https://searchfox.org/mozilla-central/rev/2e08acdf8862e68b13166970e17809a3b5d6a555/gfx/layers/apz/src/APZCTreeManager.cpp#2843
Whiteboard: [gfx-noted][wr-mvp][triage] → [wr-reserve] [gfx-noted]
Comment on attachment 8935067 [details] Bug 1423669 - Make WebRenderAPI refcounting threadsafe for use on the APZ controller thread. https://reviewboard.mozilla.org/r/205932/#review211614
Attachment #8935067 - Flags: review?(sotaro.ikeda.g) → review+
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/144cd0c4ded5 Make WebRenderAPI refcounting threadsafe for use on the APZ controller thread. r=sotaro
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Whiteboard: [wr-reserve] [gfx-noted] → [wr-mvp] [gfx-noted]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: