Closed Bug 1423689 Opened 7 years ago Closed 2 years ago

Consider building Rust code with opt-level=3

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox59 affected)

RESOLVED WONTFIX
Tracking Status
firefox59 --- affected

People

(Reporter: xidorn, Unassigned)

References

Details

It seems that we are currently building Rust code in Firefox with opt-level=2 for shipping binaries. Should we consider bringing that up to level 3? There are certain optimizations which level 2 doesn't do while level 3 does. I just discovered one case, see rust-lang/rust#46542, which I hope Rust can optimize while it doesn't do so until level 3.
See Also: → 1411081, 1380378
Product: Core → Firefox Build System

https://github.com/rust-lang/rust/issues/46542 is fixed now
Time to close this bug?

Flags: needinfo?(jmuizelaar)

It's possible to the optimization level per crate: https://doc.rust-lang.org/nightly/cargo/reference/profiles.html#overrides

So I don't think we need this bug anymore.

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(jmuizelaar)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.