Closed
Bug 1423723
Opened 7 years ago
Closed 7 years ago
Remove the reference to nsIDOMXULPopupElement in suite/common/utilityOverlay.js
Categories
(SeaMonkey :: General, enhancement)
SeaMonkey
General
Tracking
(seamonkey2.56 fixed)
RESOLVED
FIXED
seamonkey2.56
| Tracking | Status | |
|---|---|---|
| seamonkey2.56 | --- | fixed |
People
(Reporter: bgrins, Assigned: frg)
References
Details
Attachments
(1 file)
|
1.23 KB,
patch
|
stefanh
:
review+
|
Details | Diff | Splinter Review |
In Bug 1422465 I'm removing nsIDOMXULPopupElement and instead setting accessibility based off of the <panel> tagname.
After that lands, utilityOverlay.js [0] will need to use another method to detect popups (like explicit namespace / tagname check like browser/base/content/utilityOverlay.js does).
[0]: https://searchfox.org/comm-central/source/suite/common/utilityOverlay.js#1354
|
Assignee | |
Comment 1•7 years ago
|
||
Thanks for the heads up.
Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•7 years ago
|
status-seamonkey2.56:
--- → affected
Version: unspecified → Trunk
|
|
Assignee | |
Updated•7 years ago
|
Flags: needinfo?(frgrahl)
|
|
Assignee | |
Comment 2•7 years ago
|
||
Looking at the surrounding code I think the Fx check can be taken unmodified.
Flags: needinfo?(frgrahl)
Attachment #8936062 -
Flags: review?(stefanh)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8936062 [details] [diff] [review]
1423723-nsIDOMXULPopupElement.patch
Makes sense.
Attachment #8936062 -
Flags: review?(stefanh) → review+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/0979f3e2020e
Remove the reference to nsIDOMXULPopupElement in suite. r=stefanh
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•7 years ago
|
Target Milestone: --- → Seamonkey2.56
You need to log in
before you can comment on or make changes to this bug.
Description
•