Make Sqlite.jsm return an integer for getSchemaVersion, rather than a string

RESOLVED FIXED in Firefox 60

Status

()

P3
normal
RESOLVED FIXED
a year ago
10 months ago

People

(Reporter: mconley, Assigned: 17039)

Tracking

unspecified
mozilla60
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

Currently, getSchemaVersion() returns a string. According to the documentation, it should be returning an integer.

We should just return an integer.
Priority: -- → P3
Comment on attachment 8944588 [details]
Bug 1423732 - removed JSON.stringify() encapsulating result[0].getInt32(0) on line 1181 in sqlite.jsm and changed equal() to strictEqual() on lines 112, 116 and 132;

Thanks! This LGTM, though I think we should have Mak give the r+. That's a very thorough commit message. :-) In the future, just something like "Make Sqlite.jsm return an integer for getSchemaVersion" is OK; there's no need to cite changed lines or tests.
Attachment #8944588 - Flags: review?(kit) → review?(mak77)
Assignee: nobody → 17039
Status: NEW → ASSIGNED

Comment 3

a year ago
mozreview-review
Comment on attachment 8944588 [details]
Bug 1423732 - removed JSON.stringify() encapsulating result[0].getInt32(0) on line 1181 in sqlite.jsm and changed equal() to strictEqual() on lines 112, 116 and 132;

https://reviewboard.mozilla.org/r/214750/#review220470

::: commit-message-bd35f:1
(Diff revision 1)
> +Bug 1423732 - removed JSON.stringify() encapsulating result[0].getInt32(0) on line 1181 in sqlite.jsm and changed equal() to strictEqual() on lines 112, 116 and 132; r=kitcambridge

I agree that the commit message should describe the outcome of the patch, rather than what it phisically does.

::: toolkit/modules/Sqlite.jsm:1174
(Diff revision 1)
>     *
>     * This is 0 if not schema version has been set.
>     *
>     * @return Promise<int>
>     */
> +

please remove this added newline, it's not coherent with the coding style of this file.
Attachment #8944588 - Flags: review?(mak77) → review+

Comment 4

a year ago
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b19b1b50594e
Make Sqlite.jsm return an integer for getSchemaVersion. r=mak

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b19b1b50594e
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Comment hidden (spam)
You need to log in before you can comment on or make changes to this bug.