Closed
Bug 1423732
Opened 8 years ago
Closed 7 years ago
Make Sqlite.jsm return an integer for getSchemaVersion, rather than a string
Categories
(Core :: SQLite and Embedded Database Bindings, enhancement, P3)
Core
SQLite and Embedded Database Bindings
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: mconley, Assigned: 17039)
Details
Attachments
(1 file)
Currently, getSchemaVersion() returns a string. According to the documentation, it should be returning an integer.
We should just return an integer.
Updated•8 years ago
|
Priority: -- → P3
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
Comment on attachment 8944588 [details]
Bug 1423732 - removed JSON.stringify() encapsulating result[0].getInt32(0) on line 1181 in sqlite.jsm and changed equal() to strictEqual() on lines 112, 116 and 132;
Thanks! This LGTM, though I think we should have Mak give the r+. That's a very thorough commit message. :-) In the future, just something like "Make Sqlite.jsm return an integer for getSchemaVersion" is OK; there's no need to cite changed lines or tests.
Attachment #8944588 -
Flags: review?(kit) → review?(mak77)
Updated•7 years ago
|
Assignee: nobody → 17039
Status: NEW → ASSIGNED
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8944588 [details]
Bug 1423732 - removed JSON.stringify() encapsulating result[0].getInt32(0) on line 1181 in sqlite.jsm and changed equal() to strictEqual() on lines 112, 116 and 132;
https://reviewboard.mozilla.org/r/214750/#review220470
::: commit-message-bd35f:1
(Diff revision 1)
> +Bug 1423732 - removed JSON.stringify() encapsulating result[0].getInt32(0) on line 1181 in sqlite.jsm and changed equal() to strictEqual() on lines 112, 116 and 132; r=kitcambridge
I agree that the commit message should describe the outcome of the patch, rather than what it phisically does.
::: toolkit/modules/Sqlite.jsm:1174
(Diff revision 1)
> *
> * This is 0 if not schema version has been set.
> *
> * @return Promise<int>
> */
> +
please remove this added newline, it's not coherent with the coding style of this file.
Attachment #8944588 -
Flags: review?(mak77) → review+
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b19b1b50594e
Make Sqlite.jsm return an integer for getSchemaVersion. r=mak
Comment 5•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Updated•11 months ago
|
Product: Toolkit → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•