1423732 - Make Sqlite.jsm return an integer for getSchemaVersion, rather than a string

Status: RESOLVED FIXED

(Toolkit :: Storage, enhancement, P3)

Description

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Currently, getSchemaVersion() returns a string. According to the documentation, it should be returning an integer.

We should just return an integer.

Comment 1

[17039]

Attachment: Bug 1423732 - removed JSON.stringify() encapsulating result[0].getInt32(0) on line 1181 in sqlite.jsm and changed equal() to strictEqual() on lines 112, 116 and 132;

Review commit: https://reviewboard.mozilla.org/r/214750/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214750/

Comment 2

[Lina Cambridge [:lina] (ex-Mozilla)]

Comment on attachment 8944588 [details]
Bug 1423732 - removed JSON.stringify() encapsulating result[0].getInt32(0) on line 1181 in sqlite.jsm and changed equal() to strictEqual() on lines 112, 116 and 132;

Thanks! This LGTM, though I think we should have Mak give the r+. That's a very thorough commit message. :-) In the future, just something like "Make Sqlite.jsm return an integer for getSchemaVersion" is OK; there's no need to cite changed lines or tests.

Comment 3

[Marco Bonardo [:mak]]

Comment on attachment 8944588 [details]
Bug 1423732 - removed JSON.stringify() encapsulating result[0].getInt32(0) on line 1181 in sqlite.jsm and changed equal() to strictEqual() on lines 112, 116 and 132;

https://reviewboard.mozilla.org/r/214750/#review220470

::: commit-message-bd35f:1
(Diff revision 1)
> +Bug 1423732 - removed JSON.stringify() encapsulating result[0].getInt32(0) on line 1181 in sqlite.jsm and changed equal() to strictEqual() on lines 112, 116 and 132; r=kitcambridge

I agree that the commit message should describe the outcome of the patch, rather than what it phisically does.

::: toolkit/modules/Sqlite.jsm:1174
(Diff revision 1)
>     *
>     * This is 0 if not schema version has been set.
>     *
>     * @return Promise<int>
>     */
> +

please remove this added newline, it's not coherent with the coding style of this file.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b19b1b50594e
Make Sqlite.jsm return an integer for getSchemaVersion. r=mak

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b19b1b50594e

Comment 6

[[e-mail]]

>     *
>     * This is 0 if not schema version has been set.
>     *
>     * @return Promise<int>
>     */
> +

right, reomve this line.

This is gonna work.

https://top10talks.com