1423742 - Stop using Encoding::ForName in gfxFontUtils

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Bug 1423742 - Stop using Encoding::ForName in gfxFontUtils.

Review commit: https://reviewboard.mozilla.org/r/205988/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205988/

Comment 2

[Jonathan Kew [:jfkthame]]

Comment on attachment 8935146 [details]
Bug 1423742 - Stop using Encoding::ForName in gfxFontUtils.

https://reviewboard.mozilla.org/r/205988/#review211808

Nice to get rid of those strings, thanks. :)

::: gfx/thebes/gfxFontUtils.h:1010
(Diff revision 1)
>      // convert opentype name-table platform/encoding/language values to a charset name
>      // we can use to convert the name data to unicode, or "" if data is UTF16BE

This comment could use an update -- we don't map to a charset name any more, but to an Encoding object. And we don't have a special case for UTF16BE any more.

::: gfx/thebes/gfxFontUtils.cpp:1339
(Diff revision 1)
> -    { ENCODING_ID_MAC_GUJARATI,     ANY,                      "x-mac-gujarati"  },
> -    { ENCODING_ID_MAC_SIMP_CHINESE, LANG_ID_MAC_SIMP_CHINESE, "gb18030"         },
> -    { ENCODING_ID_MAC_SIMP_CHINESE, ANY,                      "gb18030"         }
> +    { ENCODING_ID_MAC_GUJARATI,     ANY,                      X_USER_DEFINED_ENCODING },
> +    { ENCODING_ID_MAC_SIMP_CHINESE, LANG_ID_MAC_SIMP_CHINESE, GB18030_ENCODING },
> +    { ENCODING_ID_MAC_SIMP_CHINESE, ANY,                      GB18030_ENCODING }
>  };
>  
> -const char* gfxFontUtils::gISOFontNameCharsets[] = 
> +const Encoding* gfxFontUtils::gISOFontNameCharsets[] = 

nit, please clean up the trailing space while you're touching this line

Comment 3

[Masatoshi Kimura [:emk]]

Comment on attachment 8935146 [details]
Bug 1423742 - Stop using Encoding::ForName in gfxFontUtils.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/205988/diff/1-2/

Comment 4

[Masatoshi Kimura [:emk]]

Comment on attachment 8935146 [details]
Bug 1423742 - Stop using Encoding::ForName in gfxFontUtils.

https://reviewboard.mozilla.org/r/205988/#review211808

> This comment could use an update -- we don't map to a charset name any more, but to an Encoding object. And we don't have a special case for UTF16BE any more.

Fixed the comment.

> nit, please clean up the trailing space while you're touching this line

Removed the extra trailing space.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40a150bb7c4f
Stop using Encoding::ForName in gfxFontUtils. r=jfkthame

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/40a150bb7c4f