Closed
Bug 1423791
Opened 7 years ago
Closed 7 years ago
Remove clang-cl workarounds from xptcstubs.cpp
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox59 fixed)
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
Details
Attachments
(1 file)
|
4.07 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
clang-cl/lld-link with ThinLTO don't like the asm in xptcstubs.cpp: https://bugs.llvm.org/show_bug.cgi?id=35482
But we don't actually need that code anymore. It was written when clang-cl couldn't handle __declspec(naked). That works now, so let's just use the original codepath.
Jeff, in the absence of Ehsan and Nathan, want to take this review?
Assignee: nobody → dmajor
Attachment #8935467 -
Flags: review?(jmuizelaar)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8935467 [details] [diff] [review]
xptcstubs
Review of attachment 8935467 [details] [diff] [review]:
-----------------------------------------------------------------
Nice.
Attachment #8935467 -
Flags: review?(jmuizelaar) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c15ae7b51eae
Remove clang-cl workarounds from xptcstubs.cpp. r=jrmuizel
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•