1423832 - Crash in geckoservo::glue::Servo_StyleSet_NoteStyleSheetsChanged

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Started to crash Tue 12-05

This bug was filed from the Socorro interface and is
report bp-3ec3640d-2b6c-435d-8ceb-e961b0171207.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll geckoservo::glue::Servo_StyleSet_NoteStyleSheetsChanged servo/ports/geckolib/glue.rs:1212
1 xul.dll mozilla::StyleSheet::RuleAdded layout/style/StyleSheet.cpp:630
2 xul.dll mozilla::ServoStyleSheet::InsertRuleInternal layout/style/ServoStyleSheet.cpp:415
3 xul.dll mozilla::StyleSheet::InsertRule layout/style/StyleSheet.cpp:577
4 xul.dll mozilla::dom::CSSStyleSheetBinding::insertRule dom/bindings/CSSStyleSheetBinding.cpp:179
5 xul.dll mozilla::dom::GenericBindingMethod dom/bindings/BindingUtils.cpp:3042
6 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:473
7 xul.dll Interpret js/src/vm/Interpreter.cpp:3096
8 xul.dll js::RunScript js/src/vm/Interpreter.cpp:423
9 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:495

=============================================================

Comment 1

[Marcia Knous [:marcia]]

In 59 this goes back to build id 20171130101246. Possible regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3f6b9aaed8cd57954e0c960cde06d25228196456&tochange=ea747bb2ffb77d1fd62b5fa6217cbee15b73d31f. ni on emilio since there are a bunch of stylo merges in that changeset.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Yup, I know about this one.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1423832: Make sure to handle gracefully rule notifications when the styleset has been detached already.

Review commit: https://reviewboard.mozilla.org/r/206340/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206340/

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8935448 [details]
Bug 1423832: Make sure to handle gracefully rule notifications when the styleset has been detached already.

https://reviewboard.mozilla.org/r/206340/#review212150

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76fec1dbe96d
Make sure to handle gracefully rule notifications when the styleset has been detached already. r=heycam

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/76fec1dbe96d

Comment 7

[Calixte Denizet (:calixte)]

No more crashes in nightly 59 after the patch landed.