Closed Bug 1423846 Opened 8 years ago Closed 8 years ago

Remove HAVE_ICONV, HAVE_ICONV_WITH_CONST_INPUT, HAVE_MBRTOWC and HAVE_WCRTOMB

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox59 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: m_kato, Assigned: hsivonen)

References

Details

Attachments

(1 file)

Bug 1423846 - Remove configure script checks for iconv and mbrtowc/tcrtomb.
59 bytes, text/x-review-board-request
glandium
: review+
Details
After fixing bug 960957, I think that no one uses HAVE_ICONV, HAVE_ICONV_WITH_CONST_INPUT, HAVE_MBRTOWC and HAVE_WCRTOMB. So we can remove this from old-configure.in
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Attachment #8935335 - Flags: review?(mh+mozilla)
Comment on attachment 8935335 [details] Bug 1423846 - Remove configure script checks for iconv and mbrtowc/tcrtomb. https://reviewboard.mozilla.org/r/206238/#review212064 Please purge xpcom/xpcom-private.h.in too.
Attachment #8935335 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8935335 [details] Bug 1423846 - Remove configure script checks for iconv and mbrtowc/tcrtomb. https://reviewboard.mozilla.org/r/206238/#review212064 Removed the undefs there. Thanks.
Pushed by hsivonen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/52e5558067af Remove configure script checks for iconv and mbrtowc/tcrtomb. r=glandium
https://hg.mozilla.org/mozilla-central/rev/52e5558067af
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox59: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: