Closed Bug 1423846 Opened 2 years ago Closed 2 years ago

Remove HAVE_ICONV, HAVE_ICONV_WITH_CONST_INPUT, HAVE_MBRTOWC and HAVE_WCRTOMB

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: m_kato, Assigned: hsivonen)

References

Details

Attachments

(1 file)

After fixing bug 960957, I think that no one uses HAVE_ICONV, HAVE_ICONV_WITH_CONST_INPUT, HAVE_MBRTOWC and HAVE_WCRTOMB.  So we can remove this from old-configure.in
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Attachment #8935335 - Flags: review?(mh+mozilla)
Comment on attachment 8935335 [details]
Bug 1423846 - Remove configure script checks for iconv and mbrtowc/tcrtomb.

https://reviewboard.mozilla.org/r/206238/#review212064

Please purge xpcom/xpcom-private.h.in too.
Attachment #8935335 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8935335 [details]
Bug 1423846 - Remove configure script checks for iconv and mbrtowc/tcrtomb.

https://reviewboard.mozilla.org/r/206238/#review212064

Removed the undefs there. Thanks.
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/52e5558067af
Remove configure script checks for iconv and mbrtowc/tcrtomb. r=glandium
https://hg.mozilla.org/mozilla-central/rev/52e5558067af
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.