Closed Bug 1423866 Opened 4 years ago Closed 4 years ago

Shutdown the vibrate thread when VR controllers are removed

Categories

(Core :: WebVR, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: daoshengmu, Assigned: daoshengmu)

Details

Attachments

(1 file)

Because nsIthread disallow shutdown himself at his own thread, We need to avoid the VRController calls its destructor when running its runnable task.

We can choose to shutdown the vibrate thread manually when removing controllers.
Assignee: nobody → dmu
Comment on attachment 8935320 [details]
Bug 1423866 - Shutdown the vibrate thread when VR controllers are removed;

https://reviewboard.mozilla.org/r/206222/#review212028

This LGTM, Thanks!
Attachment #8935320 - Flags: review?(kgilbert) → review+
Pushed by dmu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/879d3df03c13
Shutdown the vibrate thread when VR controllers are removed; r=kip
https://hg.mozilla.org/mozilla-central/rev/879d3df03c13
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.