panel-header is gone when going back from Bookmarks to Library in appMenu-multiView

RESOLVED FIXED in Firefox 59

Status

()

defect
RESOLVED FIXED
2 years ago
10 months ago

People

(Reporter: magicp.jp, Assigned: Paolo)

Tracking

Trunk
Firefox 59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(2 attachments)

Steps to reproduce:
1. Launch the latest Nightly
2. Navigate Hamburger menu > Library > Bookmarks
3. Go back Bookmarks > Library

Actual Results:
panel-header is gone when going back from Bookmarks to Library

Expected Results:
Works fine.

Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5f90362bbc80cf7f9b09e41477c244f292fc9f1c&tochange=6b5a357d277b83349223792361a0fdcc90c15305
Blocks: 1417042
Has Regression Range: --- → yes
Has STR: --- → yes
Comment on attachment 8935370 [details]
Bug 1423891 - Panel header is gone when going back from Bookmarks to Library.

https://reviewboard.mozilla.org/r/206266/#review211882

r=me with the below nit addressed.

::: browser/components/customizableui/PanelMultiView.jsm:497
(Diff revision 1)
> +      let reverse = !!aPreviousView;
> +
>        viewNode.panelMultiView = this.node;

Nit: seems like the definition of `reverse` could just come after setting `viewNode.panelMultiView`, right before the `if (!reverse)` and not insert an extra blank line (but maybe one before it if you think it's important to separate the assignment to `viewNode.panelMultiView` from the definition of `reverse` ?)
Attachment #8935370 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd86ee4a4b69
Panel header is gone when going back from Bookmarks to Library. r=Gijs
Thanks magicp for the prompt bug report and Gijs for the review!
https://hg.mozilla.org/mozilla-central/rev/cd86ee4a4b69
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
See Also: → 1424672
QA Whiteboard: [good first verify]
I have reproduced this bug with Nightly 59.0a1 (2017-12-07) on Ubuntu 16.04 LTS!

This bug's fix is verified with latest Beta!

Build ID   : 20180305193205
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
QA Whiteboard: [good first verify] → [good first verify] [bugday-20180307]
Assignee: nobody → paolo.mozmail
You need to log in before you can comment on or make changes to this bug.