1423891 - panel-header is gone when going back from Bookmarks to Library in appMenu-multiView

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[magicp]

Attachment: panel-header-is-gone.mp4

Steps to reproduce:
1. Launch the latest Nightly
2. Navigate Hamburger menu > Library > Bookmarks
3. Go back Bookmarks > Library

Actual Results:
panel-header is gone when going back from Bookmarks to Library

Expected Results:
Works fine.

Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5f90362bbc80cf7f9b09e41477c244f292fc9f1c&tochange=6b5a357d277b83349223792361a0fdcc90c15305

Comment 1

[:Paolo Amadini]

Attachment: Bug 1423891 - Panel header is gone when going back from Bookmarks to Library.

Review commit: https://reviewboard.mozilla.org/r/206266/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206266/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8935370 [details]
Bug 1423891 - Panel header is gone when going back from Bookmarks to Library.

https://reviewboard.mozilla.org/r/206266/#review211882

r=me with the below nit addressed.

::: browser/components/customizableui/PanelMultiView.jsm:497
(Diff revision 1)
> +      let reverse = !!aPreviousView;
> +
>        viewNode.panelMultiView = this.node;

Nit: seems like the definition of `reverse` could just come after setting `viewNode.panelMultiView`, right before the `if (!reverse)` and not insert an extra blank line (but maybe one before it if you think it's important to separate the assignment to `viewNode.panelMultiView` from the definition of `reverse` ?)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd86ee4a4b69
Panel header is gone when going back from Bookmarks to Library. r=Gijs

Comment 4

[:Paolo Amadini]

Thanks magicp for the prompt bug report and Gijs for the review!

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/cd86ee4a4b69

Comment 6

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 59.0a1 (2017-12-07) on Ubuntu 16.04 LTS!

This bug's fix is verified with latest Beta!

Build ID   : 20180305193205
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0