1423923 - Properly feed reverse stream to the AudioProcessingModule

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P1)

Description

[Paul Adenot (:padenot)]

It's wrong right now, unclear how it landed yesterday.

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1423923 - Properly feed reverse stream to the AudioProcessingModule.

We need to feed deinterleaved data, not interleaved data.

Review commit: https://reviewboard.mozilla.org/r/206294/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206294/

Comment 2

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8935397 [details]
Bug 1423923 - Properly feed reverse stream to the AudioProcessingModule.

https://reviewboard.mozilla.org/r/206294/#review211888

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed9d21d743cb
Properly feed reverse stream to the AudioProcessingModule. r=pehrsons

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out 1 changesets (bug 1423923) for failing /builds/worker/workspace/build/src/dom/media/webrtc/MediaEngineWebRTCAudio.cpp

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ed9d21d743cb423c7988cf4d30f57ee923d2f3f0

https://hg.mozilla.org/integration/autoland/rev/22720df5398304aff3423a02e8b04bff8cf6171e

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ed9d21d743cb423c7988cf4d30f57ee923d2f3f0&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d718ca90e07
Properly feed reverse stream to the AudioProcessingModule. r=pehrsons

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2d718ca90e07

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out bug 1423923 because it blocked the backout of bug 1397793 and bug 1397793: Unfortunately, most of the changes from bug 1397793 are part of the backout whose commit message only mentions bug 1423923. Sorry about that:

https://hg.mozilla.org/mozilla-central/rev/7c2dd8503c547d25f273f1ec7bb0d62d8d3d7051
https://hg.mozilla.org/mozilla-central/rev/57950b4441666646efcb569807e0efb2cf3eda21

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/104d8a327353
Properly feed reverse stream to the AudioProcessingModule. r=pehrsons

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/104d8a327353

Comment 10

[Paul Adenot (:padenot)]

Comment on attachment 8935397 [details]
Bug 1423923 - Properly feed reverse stream to the AudioProcessingModule.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/206294/diff/1-2/

Comment 11

[Paul Adenot (:padenot)]

clearing NI.