Closed Bug 1423929 Opened 2 years ago Closed 2 years ago

Crash in webrtc::SincResampler::Resample

Categories

(Core :: WebRTC: Audio/Video, defect, P2, critical)

59 Branch
Unspecified
Windows 10
defect

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 --- fixed

People

(Reporter: calixte, Assigned: padenot)

References

(Blocks 1 open bug)

Details

(Keywords: crash, regression, Whiteboard: [clouseau])

Crash Data

This bug was filed from the Socorro interface and is
report bp-d2005eec-85bc-416a-bebf-14b0e0171207.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll webrtc::SincResampler::Resample media/webrtc/trunk/webrtc/common_audio/resampler/sinc_resampler.cc:316
1 xul.dll webrtc::PushSincResampler::Resample media/webrtc/trunk/webrtc/common_audio/resampler/push_sinc_resampler.cc:76
2 xul.dll webrtc::AudioBuffer::CopyTo media/webrtc/trunk/webrtc/modules/audio_processing/audio_buffer.cc:171
3 xul.dll webrtc::AudioProcessingImpl::ProcessStream media/webrtc/trunk/webrtc/modules/audio_processing/audio_processing_impl.cc:829
4 xul.dll mozilla::MediaEngineWebRTCMicrophoneSource::PacketizeAndProcess dom/media/webrtc/MediaEngineWebRTCAudio.cpp:891
5 xul.dll mozilla::WebRTCAudioDataListener::NotifyInputData dom/media/webrtc/MediaEngineWebRTC.h:391
6 xul.dll mozilla::AudioCallbackDriver::DataCallback dom/media/GraphDriver.cpp:928
7 xul.dll cubeb_resampler_speex<float, cubeb_resampler_speex_one_way<float>, delay_line<float> >::fill_internal_duplex media/libcubeb/src/cubeb_resampler.cpp:242
8 xul.dll `anonymous namespace'::refill media/libcubeb/src/cubeb_wasapi.cpp:564
9 xul.dll `anonymous namespace'::refill_callback_duplex media/libcubeb/src/cubeb_wasapi.cpp:763

=============================================================

There are 1 crash in nightly 59 with buildid 20171206221407. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1397793.

[1] https://hg.mozilla.org/mozilla-central/rev/0107b3feb84b
Flags: needinfo?(padenot)
Rank: 10
Priority: -- → P2
Assignee: nobody → padenot
Flags: needinfo?(padenot)
Fixed in https://reviewboard.mozilla.org/r/206292/diff/1-2/, that has landed on central.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.