1424160 - Update class strings for IDL iterator objects and prototypes

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), defect, P3)

Description

[Timothy Gu [:TimothyGu]]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.70 Safari/537.36

Steps to reproduce:

Execute the following steps in the console:

const it = new URLSearchParams().keys();
console.log(Object.prototype.toString.call(it));
console.log(Object.prototype.toString.call(Object.getPrototypeOf(it)));
console.log(Object.getPrototypeOf(it)[Symbol.toStringTag);


Actual results:

The following is printed

[object URLSearchParamsIterator]
[object URLSearchParamsIteratorPrototype]
undefined


Expected results:

After https://github.com/heycam/webidl/pull/483:

[object URLSearchParams Iterator]
[object URLSearchParams Iterator]
URLSearchParams Iterator

Comment 1

[Timothy Gu [:TimothyGu]]

With a typo in the original description fixed:

const it = new URLSearchParams().keys();
console.log(Object.prototype.toString.call(it));
console.log(Object.prototype.toString.call(Object.getPrototypeOf(it)));
console.log(Object.getPrototypeOf(it)[Symbol.toStringTag]);

Comment 2

[Timothy Gu [:TimothyGu]]

WPT available in https://github.com/w3c/web-platform-tests/pull/8796

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Allow interfaces the have a different name for SpiderMonkey class name purposes

We want to have some class names with spaces in them, but everything assumes
that an interface identifier is in fact an identifier (e.g. uses it in C++
identifiers like namespace names).

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Add infrastructure for defining @@toStringTag on Web IDL prototypes

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Set up @@toStringTag on our synthesized iterator interfaces

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/973e3a16f6dc
part 1.  Allow interfaces the have a different name for SpiderMonkey class name purposes.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0d319aaafbe
part 2.  Add infrastructure for defining @@toStringTag on Web IDL prototypes.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5e68461d391
part 3.  Set up @@toStringTag on our synthesized iterator interfaces.  r=qdot

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/973e3a16f6dc
https://hg.mozilla.org/mozilla-central/rev/b0d319aaafbe
https://hg.mozilla.org/mozilla-central/rev/e5e68461d391