Closed Bug 142421 Opened 22 years ago Closed 13 years ago

Make nsRuleData substructs use stack more and heap less

Categories

(Core :: CSS Parsing and Computation, defect, P2)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED INVALID
Milestone:
Future

People

(Reporter: dbaron, Unassigned)

References

Details

(Whiteboard: [whitebox]) 

After doing bug 125246 (after which I envision the CSS data structs in
nsCSSDeclaration.h will no longer be used by nsCSSDeclaration.h and will thus
instead be split between nsCSSValues.h (the data types that build on nsCSSValue,
and an enum listing them) and nsCSSStructs.h (for the rule data structs
themselves)), we should make the rule data structs and their data types use much
less heap allocation in favor of making the objects bigger on the stack.  Since
we'll only have one on the stack at a time, it doesn't matter much if we make
some of them twenty words bigger.
Status: NEW → ASSIGNED
Depends on: 125246
Priority: -- → P2
Target Milestone: --- → Future
cc'ing myself
Whiteboard: [dev notes]
Whiteboard: [dev notes] → [whitebox]
How much more is left to do here, David?  You did a bunch of this in bug 125246...
Assignee: dbaron → nobody
Status: ASSIGNED → NEW
QA Contact: ian → style-system
I think this is no longer relevant.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.