Closed Bug 1424275 Opened 7 years ago Closed 6 years ago

Show element quad outline for shape-outside in CSS shapes highlighter

Categories

(DevTools :: Inspector, defect)

defect
Not set
normal

Tracking

(firefox59 verified, firefox61 verified, firefox62 verified)

VERIFIED FIXED
Firefox 59
Tracking Status
firefox59 --- verified
firefox61 --- verified
firefox62 --- verified

People

(Reporter: mpark, Assigned: mpark)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

When using shape-outside, the parts of the shape that lie outside the element's quads (default margin box) are not used. The shapes highlighter should display this box to make this fact clearer.
Comment on attachment 8935870 [details]
Bug 1424275 - Show element quad outline for shape-outside in CSS shapes highlighter.

https://reviewboard.mozilla.org/r/206730/#review212534
Attachment #8935870 - Flags: review?(gl) → review+
Should we land this?
Flags: needinfo?(mpark)
Yeah, looks good.
Flags: needinfo?(mpark)
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/49ce4e66f4d1
Show element quad outline for shape-outside in CSS shapes highlighter. r=gl
https://hg.mozilla.org/mozilla-central/rev/49ce4e66f4d1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Hi everyone, i have retested this issue on Windows 10 , Windows 7 , Mac OSx and Linux using the latest version of nightly 62.0a1 (2018-05-29) and i can Confirm it as Fixed.
I will mark it accordingly.
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
Assignee: nobody → mpark
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: