Closed Bug 1424279 Opened 2 years ago Closed 2 years ago

Search field input accepts very long query strings generating 414 errors

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla59
Tracking Status
firefox59 --- verified

People

(Reporter: madalin.cotetiu, Assigned: aswan)

References

Details

Attachments

(1 file)

Pre-requisites:
download and start this build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5297cd03d7b11b278e3439bf631b29962e7b0f25

Steps to reproduce:
1. Open about:addons
2. Enter a very long query string (10000 chars)and hit the enter button


Expected results:
The search field limits the user in entering only a finite number of characters.

Actual results:
Performing a query with a very long string breaks the search results page with a 414 error

Notes/Issues:
Verified in Ubuntu 12.04 64 bit using the build provided in here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5297cd03d7b11b278e3439bf631b29962e7b0f25
This appears to be the coming from the limit on the search API that backs the search page:
http://addons-server.readthedocs.io/en/latest/topics/api/addons.html#get--api-v3-addons-search-

So we just need t maxlength of 100 on the search textbox.  I just hit land on bug 1263313, if it sticks I'll create a follow-up patch.
Assignee: nobody → aswan
Attachment #8936471 - Flags: review?(rhelmer)
Comment on attachment 8936471 [details]
Bug 1424279 Limit search terms from about:addons to 100 characters

https://reviewboard.mozilla.org/r/207186/#review213046
Attachment #8936471 - Flags: review?(rhelmer) → review+
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/21fa53485fba
Limit search terms from about:addons to 100 characters r=rhelmer
https://hg.mozilla.org/mozilla-central/rev/21fa53485fba
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Verified as fixed in win7 x64 in FF59.
The filed is now limited to 100 characters. 
Marking bug as verified fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.