Closed Bug 1424343 Opened 3 years ago Closed 3 years ago

Stop migrating the browser.search.selectedEngine preference

Categories

(Firefox :: Search, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 59
Tracking Status
firefox58 --- fixed
firefox59 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(1 file)

We stopped using this preference in bug 1029148 for Firefox 34. In bug 1405670 we dropped migration code for search settings written before Firefox 45; we should have removed this pref migration code too.
Attached patch PatchSplinter Review
Simple code removal. The only other reference to this pref in our code is the test at https://searchfox.org/mozilla-central/rev/f5f1c3f294f89cfd242c3af9eb2c40d19d5e04e7/toolkit/components/search/tests/xpcshell/test_selectedEngine.js#16 that actually verifies that the pref has no effect anymore.
Attachment #8935861 - Flags: review?(adw)
Attachment #8935861 - Flags: review?(adw) → review+
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a7bc6776fb7
Stop migrating the browser.search.selectedEngine preference, r=adw.
https://hg.mozilla.org/mozilla-central/rev/9a7bc6776fb7
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Comment on attachment 8935861 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/Bug causing the regression]: Not a regression, just something I missed in bug 1405670.
[User impact if declined]: Slight risk of abuse for an old preference to change the user's default search engine.
[Is this code covered by automated tests?]: no.
[Has the fix been verified in Nightly?]: no.
[Needs manual test from QE? If yes, steps to reproduce]: no.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: The risk is almost non-existant 
[Why is the change risky/not risky?]: Only removing some dead migration code that has stayed in the tree for far longer than initially expected.
[String changes made/needed]: none.
Attachment #8935861 - Flags: approval-mozilla-beta?
Comment on attachment 8935861 [details] [diff] [review]
Patch

Take this for follow-up of bug 1405670. Beta58+.
Attachment #8935861 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.